Skip to content

Commit

Permalink
Merge branch 'release/0.16.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
arcticicestudio committed Jun 19, 2021
2 parents dc02a8f + 1ce7e57 commit 66424cc
Show file tree
Hide file tree
Showing 5 changed files with 93 additions and 5 deletions.
79 changes: 79 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,77 @@

<!--lint disable no-duplicate-headings no-duplicate-headings-in-section-->

# 0.16.0

![Release Date: 2021-06-19](https://img.shields.io/static/v1.svg?style=flat-square&label=Release%20Date&message=2021-06-19&colorA=4c566a&colorB=88c0d0) [![Project Board](https://img.shields.io/static/v1.svg?style=flat-square&label=Project%20Board&message=0.16.0&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/26) [![Milestone](https://img.shields.io/static/v1.svg?style=flat-square&label=Milestone&message=0.15.1&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/22)

[Show all commits][gh-compare-tag-v0.15.1_v0.16.0]

This release version mainly migrates to the [new color tokens editor suggest and quick picker widget changes introduced in Visual Studio Code version 1.57.0][vsc-rln-1.57#quick-pick-suggest-widget-color] which made the theme kind of unusable.

## Features

<details>
<summary><strong>Debug console text and input icon colors</strong> — #197 ⇄ #198 (⊶ 52432cb7)</summary>

[VS Code 1.46][vsc-rln-1.46] (May 2020) introduced [new debug console colors][vsc-rln-1.46#debug_console_tokens] for text of messages and the input icon.

The following theme keys have been added to make it conform with Nord's theme style:

- `debugConsole.infoForeground` — foreground color for info messages in the debug console.
- `debugConsole.warningForeground` — foreground color for warning messages in the debug console.
- `debugConsole.errorForeground` — foreground color for error messages in the debug console.
- `debugConsole.sourceForeground` — foreground color for source filenames in the debug console.
- `debugConsoleInputIcon.foreground` — foreground color for the debug console input marker icon.

<p align="center">
<img src="https://user-images.githubusercontent.com/7836623/121751227-06438100-cb0e-11eb-975f-f21a23dd0fbf.png" />
</p>

</details>

<details>
<summary><strong>Quick pick and suggest widget colors</strong> — #196 ⇄ #199 (⊶ 11cd6c3d)</summary>

[VS Code 1.57][vsc-rln-1.57] (May 2021) introduced [new color tokens for the “quick pick“ and “editor suggest“ widgets][vsc-rln-1.57#quick-pick-suggest-widget-color] in focused state to better align with the tree widget styles.
These changes broke the current style of Nord and made the theme har to use. The new keys have now been added to make it conform with Nord‘s style:

- `editorSuggestWidget.focusHighlightForeground` — color of the match highlights in the suggest widget when an item is focused.
- `editorSuggestWidget.selectedForeground` — foreground color of the selected entry in the suggest widget.
- `list.focusHighlightForeground` — list/tree foreground color of the match highlights on actively focused items when searching inside the list/tree.
- `quickInputList.focusForeground` — quick picker foreground color for the focused item.

<h3 align="center">Editor Suggest Widget</h3>
<p align="center"><strong>Before</strong></p>
<p align="center">
<img src="https://user-images.githubusercontent.com/7836623/122639072-148a3200-d0f8-11eb-9110-8abd4c06258c.png" width="80%">
</p>
<p align="center"><strong>After</strong></p>
<p align="center">
<img src="https://user-images.githubusercontent.com/7836623/122639070-13590500-d0f8-11eb-98c2-9b45ac6b172c.png" width="80%">
</p>

<h3 align="center">(Quick) List</h3>
<p align="center"><strong>Before</strong></p>
<p align="center">
<img src="https://user-images.githubusercontent.com/7836623/122639075-15bb5f00-d0f8-11eb-801e-640c3b352467.png" width="80%">
</p>
<p align="center"><strong>After</strong></p>
<p align="center">
<img src="https://user-images.githubusercontent.com/7836623/122639074-1522c880-d0f8-11eb-9e9e-ac5acd219e99.png" width="80%">
</p>

</details>

## Bug Fixes

<details>
<summary><strong>GitHub repository link to license in README</strong> — #195, #189 (⊶ 31236d88, 5ccef9c1) by <a href="https://github.com/Pukimaa" target="_blank" rel="noreferrer">@Pukimaa</a> and <a href="https://github.com/shmokmt" target="_blank" rel="noreferrer">@shmokmt</a></summary>

↠ The link still included the `md` file extension that was mainly used for license files some years ago.

</details>

# 0.15.1

![Release Date: 2021-02-01](https://img.shields.io/static/v1.svg?style=flat-square&label=Release%20Date&message=2021-02-01&colorA=4c566a&colorB=88c0d0) [![Project Board](https://img.shields.io/static/v1.svg?style=flat-square&label=Project%20Board&message=0.15.1&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/25) [![Milestone](https://img.shields.io/static/v1.svg?style=flat-square&label=Milestone&message=0.15.1&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/21)
Expand Down Expand Up @@ -1109,3 +1180,11 @@ Detailed information about features, supported languages and install instruction
[gh-compare-tag-v0.15.0_v0.15.1]: https://github.com/arcticicestudio/nord-visual-studio-code/compare/v0.15.0...v0.15.1
[npm-@arcticicestudio/eslint-config-base]: https://www.npmjs.com/package/@arcticicestudio/eslint-config-base
[npm-eslint-config-arcticicestudio-base]: https://www.npmjs.com/package/eslint-config-arcticicestudio-base

<!-- v0.16.0 -->

[gh-compare-tag-v0.15.1_v0.16.0]: https://github.com/arcticicestudio/nord-visual-studio-code/compare/v0.15.1...v0.16.0
[vsc-rln-1.46]: https://code.visualstudio.com/updates/v1_46
[vsc-rln-1.46#debug_console_tokens]: https://code.visualstudio.com/updates/v1_46#_new-debug-console-theme-colors
[vsc-rln-1.57]: https://code.visualstudio.com/updates/v1_57
[vsc-rln-1.57#quick-pick-suggest-widget-color]: https://code.visualstudio.com/updates/v1_57#_updated-quick-pick-suggest-widget-color
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ The guide also includes information about [minimal, complete, and verifiable exa

<p align="center">Copyright &copy; 2017-present <a href="https://www.arcticicestudio.com" target="_blank">Arctic Ice Studio</a> and <a href="https://www.svengreb.de" target="_blank">Sven Greb</a></p>

<p align="center"><a href="https://github.com/arcticicestudio/nord-visual-studio-code/blob/develop/LICENSE.md"><img src="https://img.shields.io/static/v1.svg?style=flat-square&label=License&message=MIT&logoColor=eceff4&logo=github&colorA=4c566a&colorB=88c0d0"/></a></p>
<p align="center"><a href="https://github.com/arcticicestudio/nord-visual-studio-code/blob/develop/LICENSE"><img src="https://img.shields.io/static/v1.svg?style=flat-square&label=License&message=MIT&logoColor=eceff4&logo=github&colorA=4c566a&colorB=88c0d0"/></a></p>

[nord-comm]: https://www.nordtheme.com/community
[nord-contrib-guide-branching]: https://github.com/arcticicestudio/nord/blob/develop/CONTRIBUTING.md#branch-organization
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nord-visual-studio-code",
"displayName": "Nord",
"description": "An arctic, north-bluish clean and elegant Visual Studio Code theme.",
"version": "0.15.1",
"version": "0.16.0",
"publisher": "arcticicestudio",
"author": {
"name": "Arctic Ice Studio",
Expand Down Expand Up @@ -73,7 +73,7 @@
"lint:js": "eslint --ext .js,.jsx .",
"lint:json": "eslint --ext .json .",
"lint:md": "remark --no-stdout . \".github/**/*.md\"",
"package": "vsce package --out nord-visual-studio-code.vsix"
"package": "vsce package"
},
"devDependencies": {
"@arcticicestudio/eslint-config-base": ">=0.5.0 <1.0.0",
Expand Down
11 changes: 10 additions & 1 deletion themes/nord-color-theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
"button.background": "#434c5e",
"button.foreground": "#d8dee9",
"button.hoverBackground": "#4c566a",
"debugConsole.infoForeground": "#88c0d0",
"debugConsole.warningForeground": "#ebcb8b",
"debugConsole.errorForeground": "#bf616a",
"debugConsole.sourceForeground": "#616e88",
"debugConsoleInputIcon.foreground": "#81a1c1",
"debugExceptionWidget.background": "#4c566a",
"debugExceptionWidget.border": "#2e3440",
"debugToolBar.background": "#3b4252",
Expand Down Expand Up @@ -93,8 +98,10 @@
"editorSuggestWidget.background": "#2e3440",
"editorSuggestWidget.border": "#3b4252",
"editorSuggestWidget.foreground": "#d8dee9",
"editorSuggestWidget.focusHighlightForeground": "#88c0d0",
"editorSuggestWidget.highlightForeground": "#88c0d0",
"editorSuggestWidget.selectedBackground": "#434c5e",
"editorSuggestWidget.selectedForeground": "#d8dee9",
"extensionButton.prominentForeground": "#d8dee9",
"extensionButton.prominentBackground": "#434c5e",
"extensionButton.prominentHoverBackground": "#4c566a",
Expand Down Expand Up @@ -125,6 +132,7 @@
"list.hoverForeground": "#eceff4",
"list.focusForeground": "#d8dee9",
"list.focusBackground": "#88c0d099",
"list.focusHighlightForeground": "#eceff4",
"list.hoverBackground": "#3b4252",
"list.dropBackground": "#88c0d099",
"list.highlightForeground": "#88c0d0",
Expand Down Expand Up @@ -190,6 +198,7 @@
"pickerGroup.border": "#3b4252",
"pickerGroup.foreground": "#88c0d0",
"progressBar.background": "#88c0d0",
"quickInputList.focusForeground": "#2e3440",
"scrollbar.shadow": "#00000066",
"scrollbarSlider.activeBackground": "#434c5eaa",
"scrollbarSlider.background": "#434c5e99",
Expand Down Expand Up @@ -948,7 +957,7 @@
"source.js meta.embedded.line meta.brace.round",
/* Required for extension `mgmcdermott.vscode-language-babel`. */
"source.js string.quoted.template meta.brace.square",
"source.js string.quoted.template meta.brace.round",
"source.js string.quoted.template meta.brace.round"
],
"settings": {
"foreground": "#ECEFF4"
Expand Down

0 comments on commit 66424cc

Please sign in to comment.