Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search #35

Open
not-matthias opened this issue Oct 4, 2023 · 4 comments
Open

Search #35

not-matthias opened this issue Oct 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@not-matthias
Copy link
Owner

Should use WASM-based libraries to reduce the network footprint:

@not-matthias not-matthias added the enhancement New feature or request label Oct 4, 2023
@SeniorMars
Copy link
Contributor

SeniorMars commented Jun 14, 2024

Counterpoint: elasticlunr is easy to built with and using pagefind/tinysearch will make it hard to use with github actions / require you to self host.

@SeniorMars
Copy link
Contributor

Do you want me to implement this with elasticlunr? I think it is a good idea for a default. We can disable it by default too.

@not-matthias
Copy link
Owner Author

Yeah, sounds good. Don't think it'll make a big difference if it's wasm or js. Feel free to use elasticlunr. And keeping it turned off by default is also a good idea. 👍

@soumendrak
Copy link
Contributor

@SeniorMars / @not-matthias
Is there any progress on this feature? Or can you please guide me which all files do I need to add/update for this search functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants