Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a twemojify button for our Linux users #17

Open
elamperti opened this issue Oct 14, 2016 · 7 comments
Open

Feature: Add a twemojify button for our Linux users #17

elamperti opened this issue Oct 14, 2016 · 7 comments

Comments

@elamperti
Copy link

Emoji appears as squares for most of the characters. Can we discuss here how would be the best way to add a twemojify! button (or a similar feature)?
It would enable Linux users to use mojibrag too! (probably applies to users of old Windows versions as well)

messages

@notwaldorf
Copy link
Owner

That's a Linux problem, not the app's fault, unfortunately (it just uses your native emoji font to render). However, Here's how to fix that!

@notwaldorf
Copy link
Owner

Actually, I'll reopen and rename this issue as a feature request, since a Twemojify button isn't a bad idea

@notwaldorf notwaldorf reopened this Oct 14, 2016
@notwaldorf notwaldorf changed the title Emoji are not visible using Linux Feature: Add a twemojify button for our Linux users Oct 14, 2016
@wongmjane
Copy link
Contributor

I am using Chromium on a Linux distro with Noto Color Emoji and it works.

screenshot from 2016-10-17 16-35-42

@anxolerd
Copy link
Contributor

@wongmjane the same here, but there are a lot of guys who do not use Noto Color Emoji font and see that ugly squares.

@notwaldorf
Copy link
Owner

notwaldorf commented Oct 17, 2016

@anxolerd Yes, but that also means they don't see any emoji ever, on any web page, which sounds like a more generic problem than the fact it doesn't work in this app.

@anxolerd
Copy link
Contributor

@notwaldorf: Is there any good way to insert html into Polymer template? And is there any way to escape html string outside the Polymer template? What I want to do is:

<template>{prepare(someData)}</template>
...
function prepare(data) {
    var escaped = escapeHtml(data);
    return wrapIntoHtml(escaped);
}

That might work pretty well with twemoji to display emoji on page.

@elamperti
Copy link
Author

@anxolerd hey, I have the same problem trying to change the messages, we should solve it safely to avoid XSS.

I uploaded my progress in this branch, hope it helps you or someone else working on this too.

Other stuff related to this feature:

  • Each emoji in the preview area has a <select> with emoji options (and -surprise!- it doesn't handle images well), so it should be changed to something better (maybe iron-dropdown?)
  • Once we have twemoji added, there are many elements that should be parsed (page title, lang switcher, channel names, the feed, preview area). Instead of binding everything we may run it once for each element when twemoji loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants