Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gender selection from user profile #1

Open
jshprentz opened this issue May 21, 2020 · 2 comments
Open

Remove gender selection from user profile #1

jshprentz opened this issue May 21, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jshprentz
Copy link
Collaborator

Issue

Fab Manager requires users to select a gender (Man/Woman) in their user profile. New users are blocked from Fab Manager until they complete their profile. A few reviewers recommended (demanded) removing gender.

May 19, Bob Coggeshall marked up the user form.
https://nova-labs-org.slack.com/archives/C012L53T5KQ/p1589892338237800

image

May 19, Jeanne Marshall, "In registering, I don’t understand why we’re tracking gender."
https://nova-labs-org.slack.com/archives/C012L53T5KQ/p1589946387281900

May 21, Jennyfer Peterson, "Any news on the removal of gender from the "enrollmante" process? That is a major showstopper for our community."

Analysis

May 21, Joel Shprentz, "Fab Manager uses gender in 73 source files. It is collected in user profile forms and imports. Users are blocked from reservations unless they specify a gender. Statistics can be filtered by gender. Mostly, gender drives pronoun selection throughout the user interface. For example,"
https://nova-labs-org.slack.com/archives/C012L53T5KQ/p1590070578308900?thread_ts=1590067118.305000&cid=C012L53T5KQ

image

May 21, Christopher Sexton, Looking at gender, it seems like the underlying model and schema don’t require it: https://github.com/sleede/fab-manager/blob/master/db/schema.rb#L683

Also they store it is a boolean, which is just odd:
https://github.com/sleede/fab-manager/blob/master/app/models/statistic_profile.rb#L27-L29
(male is true, female is false :face_palm: )

Looks like there is no enforcing gender to be non-nil in the ruby code, but the JS front end does that.

@jshprentz
Copy link
Collaborator Author

Forked https://github.com/sleede/fab-manager and added gender-options branch to work on this.

@jshprentz
Copy link
Collaborator Author

Recommend adding two more environment variables:

GENDER_ENABLED Display gender choices in user profile forms. Show gender pronouns in user interface. Filter statistics by gender.

GENDER_REQUIRED Require gender to have a value in user profiles.

@jshprentz jshprentz added the enhancement New feature or request label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant