Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletConnect. Refresh lead to duplicates in database #2691

Open
stepanLav opened this issue Nov 20, 2024 · 0 comments · Fixed by #2740
Open

WalletConnect. Refresh lead to duplicates in database #2691

stepanLav opened this issue Nov 20, 2024 · 0 comments · Fixed by #2740
Assignees
@Asmadek
Labels
Bug Issues & PRs that addressing a bug
Milestone
Milestone 4

Comments

@stepanLav
Copy link
Member

Description

When user perform a reconnect for WalletConnect added wallet it may lead to duplicates in database.

Example:

Kapture.2024-11-20.at.11.26.37.mp4

Steps to Reproduce

  1. Add WalletConnect wallet via NovaWallet
  2. Perform Reconnect flow a multiple times
  • Check database accounts table

Expected Behavior

After reconnect all accounts will be updated

Actual Behavior

Some times reconnect will lead to duplications in the table

Environment

3f03535
@stepanLav stepanLav added the Bug Issues & PRs that addressing a bug label Nov 20, 2024
@stepanLav stepanLav changed the title WalletConnect. Reconnect lead to duplicates in database WalletConnect. Refresh lead to duplicates in database Nov 20, 2024
@pgolovkin pgolovkin modified the milestones: Milestone 5, Milestone 4 Nov 20, 2024
@Asmadek Asmadek moved this from Todo to Development in Nova Spektr development Nov 21, 2024
@Asmadek Asmadek moved this from Development to In Review in Nova Spektr development Nov 27, 2024
@Asmadek Asmadek moved this from In Review to Ready for Test in Nova Spektr development Nov 27, 2024
@Asmadek Asmadek linked a pull request Nov 27, 2024 that will close this issue
fix: update wc pairing #2740
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Asmadek Asmadek

Labels
Bug Issues & PRs that addressing a bug
Projects
Nova Spektr development
Status: Ready for Test
Milestone
Milestone 4
Development

Successfully merging a pull request may close this issue.

fix: update wc pairing novasamatech/nova-spektr
4 participants
@pgolovkin @Asmadek @stepanLav @admin-novasama