-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E fail slack notification + scheduled API tests #5500
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @AliaksandrRyzhou , very clean! Added one question for review, it's non-blocking. ⚡
@@ -186,12 +200,25 @@ jobs: | |||
path: playwright-report | |||
retention-days: 14 | |||
|
|||
- name: Notify Slack Action | |||
uses: ravsamhq/notify-slack-action@v2 | |||
if: ${{ always() && inputs.slack_notification }} && ${{ needs.e2e_web.result == 'failure' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Why is the always()
expression (ref to docs) needed here? It seems redundant when the inputs.slack_notification
is taking effect already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rifont if some step of the merge-reports job fails then a job stops on a failed step and we won't receive a notification. Because the merge-reports job is a part of WEB tests we have to get a notification even when this job fails.
We want to be informed about how e2e tests are going.
These changes will add the Slack notification when e2e tests fail to tell us that a workflow has been disabled.
Also, as it was discussed here I've added API tests to the schedule