Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E fail slack notification + scheduled API tests #5500

Merged
merged 18 commits into from
May 7, 2024

Conversation

AliaksandrRyzhou
Copy link
Contributor

@AliaksandrRyzhou AliaksandrRyzhou commented May 6, 2024

We want to be informed about how e2e tests are going.
image

These changes will add the Slack notification when e2e tests fail to tell us that a workflow has been disabled.

Also, as it was discussed here I've added API tests to the schedule

Copy link

linear bot commented May 6, 2024

Copy link

netlify bot commented May 6, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 03f232f
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663a2580fa1c2600081cbb6e
😎 Deploy Preview https://deploy-preview-5500--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 03f232f
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663a2580cd72280007339076
😎 Deploy Preview https://deploy-preview-5500--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @AliaksandrRyzhou , very clean! Added one question for review, it's non-blocking. ⚡

@@ -186,12 +200,25 @@ jobs:
path: playwright-report
retention-days: 14

- name: Notify Slack Action
uses: ravsamhq/notify-slack-action@v2
if: ${{ always() && inputs.slack_notification }} && ${{ needs.e2e_web.result == 'failure' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why is the always() expression (ref to docs) needed here? It seems redundant when the inputs.slack_notification is taking effect already‏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rifont if some step of the merge-reports job fails then a job stops on a failed step and we won't receive a notification. Because the merge-reports job is a part of WEB tests we have to get a notification even when this job fails.

@Cliftonz Cliftonz merged commit 557b7e3 into next May 7, 2024
25 checks passed
@Cliftonz Cliftonz deleted the inf-388-slack-alert-e2e-fail branch May 7, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants