Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: aws_fota: Add single url to aws_fota job doc parsing #10974

Closed
wants to merge 1 commit into from
Closed

net: lib: aws_fota: Add single url to aws_fota job doc parsing #10974

wants to merge 1 commit into from

Conversation

Crzyrndm
Copy link
Contributor

@Crzyrndm Crzyrndm commented Apr 27, 2023

This functionality was previously proposed as part of #1986 but that PR was closed as stale. The HTTPS parts have since been added to download client, but the single url for aws_fota has not. The single url capability is required to use placeholder pre-signed S3 urls with AWS IoT
See "Presigned URLs" section here: https://docs.aws.amazon.com/iot/latest/developerguide/create-manage-jobs.html

@Crzyrndm Crzyrndm requested a review from rlubos as a code owner April 27, 2023 22:44
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 27, 2023
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Apr 27, 2023
This functionality was previously proposed as part of #1986 but that
PR was closed as stale. The HTTPS parts have since been added to download
client, but the single url for aws_fota has not. The single url capability is
required to use placeholder pre-signed S3 urls with AWS IoT
https://docs.aws.amazon.com/iot/latest/developerguide/create-manage-jobs.html

Signed-off-by: Joshua Crawford <joshua.crawford@levno.com>
@@ -40,7 +40,34 @@ void test_parse_job_execution(void)
TEST_ASSERT_EQUAL_STRING(expected_file_path, file_path);
}

void test_parse_malformed_job_execution(void)
#if !defined(CONFIG_HTTP_PARSER_URL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the relevant configuration options are enabled in the prj.conf for the test, this conditional is not needed.

@nrfconnect nrfconnect deleted a comment from fnawratil Jul 31, 2023
@simensrostad
Copy link
Contributor

Superseded by #11938.

@Crzyrndm Crzyrndm deleted the aws-fota-url branch August 3, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants