Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Update Matter revision to pull fixes for NCS 2.4.1 #11498

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

ArekBalysNordic
Copy link
Contributor

The newest version of sdk-connectedhomeip contains fixes that are needed for NCS 2.4.1 release.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Jun 13, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 13, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@v2.4.0 nrfconnect/sdk-connectedhomeip@d6ddd68 (v2.4-branch) nrfconnect/sdk-connectedhomeip@v2.4.0..d6ddd681

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 13, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jun 14, 2023
@github-actions github-actions bot removed the doc-required PR must not be merged without tech writer approval. label Jun 16, 2023
@@ -1778,7 +1778,7 @@ endpoint 0 {
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap default = 1;
ram attribute featureMap default = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should be marked as "callback" aka "external" as the default value doesn't really mean anything.

@LuDuda
Copy link
Contributor

LuDuda commented Jun 21, 2023

I was wondering if we should bump the revisions of applications, like here:

There are multiple of these, e.g. in the Matter Weather Station.
CONFIG_MCUBOOT_IMAGE_VERSION="2.4.0+0"

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 22, 2023
doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
doc/nrf/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
@ArekBalysNordic ArekBalysNordic added this to the 2.4.1 milestone Jul 3, 2023
The newest version of sdk-connectedhomeip contains fixes that
are needed for NCS 2.4.1 release

- Updated the MCUBoot image version in preparation to
NCS 2.4.1.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
* Changed feature map from 2 to 0 for software diag cluster
* Changed cluster revision from 1 to 2 for basic info cluster

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
We noticed that IPC priority on nRF5340 is not set by default.
We need to set it in DTS to be sure that the IPC thread does not
collide with other threads.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
@nordicjm nordicjm merged commit ad1de38 into nrfconnect:v2.4-branch Jul 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants