Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_modem: allow modem shutdown in flight mode #11590

Merged
merged 1 commit into from
Jun 23, 2023
Merged

lib: nrf_modem: allow modem shutdown in flight mode #11590

merged 1 commit into from
Jun 23, 2023

Conversation

eivindj-nordic
Copy link
Contributor

Allow the modem to be shut down when in flight mode (CFUN=4).

@eivindj-nordic eivindj-nordic self-assigned this Jun 21, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 21, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 21, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

tokangas
tokangas approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@tokangas tokangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. According to the modem team, both functional modes 0 and 4 should be fine before shutdown.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 21, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@eivindj-nordic
lib: nrf_modem: allow modem shutdown in flight mode
f2a6f76 
Allow the modem to be shut down when in flight mode (CFUN=4).

Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
@nordicjm nordicjm merged commit d53b485 into nrfconnect:main Jun 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemrey lemrey lemrey approved these changes

@tokangas tokangas tokangas approved these changes

@divipillai divipillai divipillai approved these changes

@MirkoCovizzi MirkoCovizzi Awaiting requested review from MirkoCovizzi

@rlubos rlubos Awaiting requested review from rlubos

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees

@eivindj-nordic eivindj-nordic

Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eivindj-nordic @NordicBuilder @lemrey @tokangas @divipillai @nordicjm