Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find My: fixes for the next v2.4 minor releases #11651

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Find My: fixes for the next v2.4 minor releases #11651

merged 1 commit into from
Jun 30, 2023

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jun 29, 2023

Updated Find My and Zephyr revision to include fixes for the v2.4.0 release of the Find My add-on for nRF Connect SDK that will be part of the next minor release.

Ref: NCSDK-22417

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Jun 29, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 29, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
find-my nrfconnect/sdk-find-my@v2.4.0 https://github.com/nrfconnect/sdk-find-my/commit/efb1ff413902e6c80f7713f00095868d70013194 (main) nrfconnect/sdk-find-my@v2.4.0..efb1ff41
zephyr nrfconnect/sdk-zephyr@b57a748 nrfconnect/sdk-zephyr@75f6793 (v3.3.99-ncs1-branch) nrfconnect/sdk-zephyr@b57a7488..75f67930

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 29, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-tfm X
test-fw-nrfconnect-thread X
test-sdk-find-my X
test-sdk-homekit X

test-sdk-find-my: added because there was no .github/test-spec.yml in 'find-my'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@kapi-no kapi-no added this to the 2.4.1 milestone Jun 29, 2023
@shanthanordic shanthanordic self-requested a review June 30, 2023 09:56
shanthanordic
shanthanordic approved these changes Jun 30, 2023
View reviewed changes
Copy link

@shanthanordic shanthanordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok to merge this PR with lwm2m and thingy91 failures. However I would need +1 from @rafpelc for RPC failures

@rafpelc
Copy link

rafpelc commented Jun 30, 2023

RPC failures not related to PR, can be merged

rlubos
rlubos reviewed Jun 30, 2023
View reviewed changes
west.yml Outdated Show resolved Hide resolved
@kapi-no
manifest: update Find My and Zephyr revision
c24d44d 
Updated Find My and Zephyr revision to include fixes for the v2.4.0
release of the Find My add-on for nRF Connect SDK that will be part
of the next minor release.

Ref: NCSDK-22417

Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
@NordicBuilder NordicBuilder removed the DNM label Jun 30, 2023
@kapi-no kapi-no removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 30, 2023
@kapi-no kapi-no requested a review from miha-nordic June 30, 2023 11:03
@kapi-no
Copy link
Contributor Author

kapi-no commented Jun 30, 2023

CC: @miha-nordic

@rlubos rlubos merged commit c52422c into nrfconnect:v2.4-branch Jun 30, 2023
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

@rafpelc rafpelc rafpelc approved these changes

@mkapala-nordic mkapala-nordic mkapala-nordic approved these changes

@shanthanordic shanthanordic shanthanordic approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

@tejlmand tejlmand Awaiting requested review from tejlmand tejlmand is a code owner

@miha-nordic miha-nordic Awaiting requested review from miha-nordic

Assignees
No one assigned
Labels
manifest manifest-find-my manifest-zephyr
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@kapi-no @NordicBuilder @rafpelc @rlubos @mkapala-nordic @shanthanordic