samples: Bluetooth: encrypt llpm sample #11720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintv
requested review from
alwa-nordic,
carlescufi and
KAGA164
as code owners
github-actions
bot
added
the
changelog-entry-required
jori-nordic
reviewed
Jul 6, 2023
| { | ||
| printk("Security changed: level %i, err: %i\n", level, err); | ||
|
|
||
| /*Start service discovery when link is encrypted*/ |
There was a problem hiding this comment.
can you add a check that err is non-zero and disconnect/assert if that's the case?
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
It makes most sense to demonstrate llpm on an ecrypted link. Also setting down conection interval to the smallest bluetooth allows. 7.5ms. Since encyrpting the link takes quite a lot of packets back and forth, this will speed up setup. But also it makes sense that the sample compares the best bluetooth can do with the best llpm can do. Signed-off-by: Martin Tverdal <martin.tverdal@nordicsemi.no>
|
|
|
@martintv you might want to pass the cmdline option |
jori-nordic
approved these changes
Jul 6, 2023
alwa-nordic
approved these changes
Jul 7, 2023
martintv
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes most sense to demonstrate llpm on an ecrypted link. Also setting down conection interval to the smallest bluetooth allows. 7.5ms. Since encyrpting the link takes quite a lot of packets back and forth, this will speed up setup. But also it makes sense that the sample compares the best bluetooth can do with the best llpm can do.