samples: matter: added thermostat sample application #11737
Conversation
LipinskiPNordicSemi
requested review from
Damian-Nordic,
kkasperczyk-no and
carlescufi
as code owners
github-actions
bot
added
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
markaj-nordic
requested review from
doublemis1,
ArekBalysNordic,
markaj-nordic and
LuDuda
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
6 times, most recently
from
0a1e8e0
to
7823562
Compare
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
11 times, most recently
from
13a39d0
to
c4845c0
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
4 times, most recently
from
e54788f
to
1d58e0b
Compare
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
2 times, most recently
from
733bc23
to
bcd97c5
Compare
|
Just an update on docs: I've pushed my edits on Friday and I see them correctly included and rebased by @LipinskiPNordicSemi . I'm waiting for @doublemis1 to help with the memory requirement values to give my final approval. In the meantime, @markaj-nordic , could you be so kind to give one last pass to the thermostat's README, to make sure all is correct content-wise and feature-wise? |
On it. |
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
3 times, most recently
from
32c6d86
to
5baa77f
Compare
greg-fer
force-pushed
the
ncs-thermostat-sample
branch
from
4eaef6d
to
62ff5d6
Compare
There was a problem hiding this comment.
Added only last minor comments, overall LGTM. Thanks @LipinskiPNordicSemi
samples/matter/thermostat/src/temperature_measurement/simulated_temp.cpp
Outdated
Show resolved
Hide resolved
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
from
62ff5d6
to
cae4fe8
Compare
greg-fer
force-pushed
the
ncs-thermostat-sample
branch
from
cae4fe8
to
62ff5d6
Compare
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
from
62ff5d6
to
01fe2c8
Compare
Created example application for thermostat device, able to read temperature from external temperature sensor or use mocked temperature values. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
LipinskiPNordicSemi
force-pushed
the
ncs-thermostat-sample
branch
from
01fe2c8
to
8104c0e
Compare
Created example application for thermostat device, able to read temperature from external temperature sensor or use mocked temperature values.