nrf_security: Remove random_ext.c #11741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vge0rge
requested review from
frkv,
vili-nordic,
joerchan,
SebastianBoe,
mswarowsky and
rlubos
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
SebastianBoe
reviewed
Jul 7, 2023
SebastianBoe
approved these changes
Jul 7, 2023
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
joerchan
reviewed
Jul 7, 2023
Vge0rge
force-pushed
the
remove_random_ext
branch
2 times, most recently
from
d07cb9f
to
c5ce3b2
Compare
Vge0rge
force-pushed
the
remove_random_ext
branch
3 times, most recently
from
c4bc656
to
c483255
Compare
joerchan
reviewed
Jul 10, 2023
Vge0rge
force-pushed
the
remove_random_ext
branch
from
c483255
to
53dc114
Compare
joerchan
approved these changes
Jul 11, 2023
Vge0rge
force-pushed
the
remove_random_ext
branch
from
7b0f315
to
edd4e45
Compare
torsteingrindvik
approved these changes
Jul 11, 2023
Vge0rge
force-pushed
the
remove_random_ext
branch
4 times, most recently
from
e680730
to
7adce69
Compare
Remove the random_ext.c file and the MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG option since it is not used anymore by the Oberon PSA core. With the current configuration the options: PSA_CRYPTO_DRIVER_ALG_CTR_DRBG_* are used to specifiy the random number generator algorithm. Ref: NCSDK-21868 Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
The crypto tests only use the external_rng function and they only test for one configuration where MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG is enabled. This removes the unused code and configurations. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Vge0rge
force-pushed
the
remove_random_ext
branch
from
7adce69
to
c405a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the random_ext.c file and the MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG option since it is not used anymore by the Oberon PSA core.
With the current configuration the options:
PSA_CRYPTO_DRIVER_ALG_CTR_DRBG_*
are used to specifiy the random number generator algorithm.
Ref: NCSDK-21868
Signed-off-by: Georgios Vasilakis georgios.vasilakis@nordicsemi.no