Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: cellular: MMSS: Support Wi-Fi #11863

Merged
merged 6 commits into from
Aug 16, 2023
Merged

samples: cellular: MMSS: Support Wi-Fi #11863

merged 6 commits into from
Aug 16, 2023

Conversation

glarsennordic
Copy link
Contributor

@glarsennordic glarsennordic commented Jul 24, 2023 •
edited
Loading

Adds Wi-Fi support to MMSS, and several related supporting changes to NCS

IRIS-4800

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 24, 2023
@glarsennordic
Copy link
Contributor Author

glarsennordic commented Jul 24, 2023 •
edited
Loading

Not thoroughly tested

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 1, 2023
@glarsennordic glarsennordic marked this pull request as ready for review August 2, 2023 00:13
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@glarsennordic glarsennordic force-pushed the MMSS_L2AC_WIFI branch 2 times, most recently from 31e683b to 560e3fa Compare August 4, 2023 20:52
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 4, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

jayteemo
jayteemo reviewed Aug 4, 2023
View reviewed changes
subsys/net/lib/nrf_cloud/src/nrf_cloud_transport.c Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/overlay_nrf7002ek_wifi_no_lte.conf Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/CMakeLists.txt Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/Kconfig.nrf_cloud_mqtt Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
wiba-nordic
wiba-nordic requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now quite a few places with detailed instructions with lots of "Next, [...]". These should be numbered steps, possibly split into a couple of different parts with their own introductions.

There's also probably several places where I missed the placeholder text.

samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/overlay_nrf7002ek_wifi_no_lte.conf Outdated Show resolved Hide resolved
wiba-nordic
wiba-nordic requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits left, and a couple of formatting issues.

samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_mqtt_multi_service/README.rst Outdated Show resolved Hide resolved
@glarsennordic glarsennordic force-pushed the MMSS_L2AC_WIFI branch 3 times, most recently from bfe196e to d2eab9a Compare August 10, 2023 18:35
@glarsennordic
Copy link
Contributor Author

@rlubos No need to review this, you got errantly tagged because I have rebased on top of #11900 which is not yet merged

@glarsennordic
Copy link
Contributor Author

@wiba-nordic Ignore first 5 commits for your re-review. They are from #11900

wiba-nordic
wiba-nordic requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very small change resulting from us going on top of the other PR, otherwise looks good.

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved
@glarsennordic
net: lib: nrf_cloud: Discourage use of PROVISION_CERTIFICATES
a13a7f5 
Add an automatic error message printed to UART emphasising the fact that
CONFIG_NRF_CLOUD_PROVISION_CERTIFICATES is inherently insecure and
should only be used for testing purposes.

Also mark NRF_CLOUD_PROVISION_CERTIFICATES as experimental.

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@glarsennordic
samples: cellular: multi_service: Support CLOUD_PROVISION_CERTIFICATES
9ca5a0b 
Slightly modify CMakeLists.txt to automatically search for secrets in
local certs directory if CONFIG_NRF_CLOUD_PROVISION_CERTIFICATES is
enabled.

Also add .gitignore entry to prevent said certs folder from ever being
accidentally committed.

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@glarsennordic
samples: cellular: multi_service: Trigger date_time updates on connect
58f3368 
When CONFIG_DATE_TIME_AUTO_UPDATE is disabled, manually trigger
date_time timestamp update whenever network connection is achieved

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@glarsennordic
samples: cellular: multi_service: Handle connection failure immediately
ce7e476 
If NRF_CLOUD_EVT_TRANSPORT_CONNECT_ERROR is raised by nrf_cloud,
reset connection and retry immediately rather than wait for the
readiness timeout.

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@glarsennordic
samples: cellular: multi_service: Support Wi-Fi connectivity
5f877ad 
Adds overlay to use Wi-Fi conn_mgr layer instead of LTE conn_mgr layer.
Also removes a couple remaining dependencies on the nrf9160 modem.

IRIS-4800

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@glarsennordic
samples: cellular: multi_service: Document Wi-Fi provisioning process
89145bb 
Add docs explaining how to build and provision for Wi-Fi connectivity.

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@nordicjm nordicjm merged commit d39354f into nrfconnect:main Aug 16, 2023
16 checks passed
@jayteemo jayteemo mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plskeggs plskeggs plskeggs approved these changes

@jayteemo jayteemo jayteemo approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@tony-le-24 tony-le-24 Awaiting requested review from tony-le-24

@rlubos rlubos Awaiting requested review from rlubos

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glarsennordic @NordicBuilder @plskeggs @jayteemo @wiba-nordic @nordicjm