-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsys: fota_download: correcting URI check #11904
subsys: fota_download: correcting URI check #11904
Conversation
VTPeltoketo
commented
Jul 28, 2023
- HASH checksums are used to validate changed URI
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
5639852
to
124cbc5
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks functionally correct.
Please remove the extra Kconfig dependency and rename the variables to *_hash
instead of *_sha256
13f795f
to
8559759
Compare
8559759
to
6d179cd
Compare
7e01b69
to
e8442c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash both of these commits together. It is basically just one change.
7d5a0d0
to
013aeae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is either to speed up the check or to remove strcmp
right? Anyways so far changes looks good to me.
@sigvartmh There were two reasons: 1) There was a bug in the original code, the pointers of strcmp pointed to the same address. 2) strcmp requires a second buffer of URI and the buffer is quite big. We are running out of RAM and second buffer is not a viable solution. |
8026ab8
to
0ebde9a
Compare
|
||
* Updated: | ||
|
||
* Verifies if download started with the same URI and resumes the interrupted download. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Verifies if download started with the same URI and resumes the interrupted download. | |
* The library now verifies whether the download started with the same URI and resumes the interrupted download. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
- HASH checksums are used to validate changed URI Signed-off-by: Veli-Tapani Peltoketo <veli-tapani.peltoketo@nordicsemi.no>
804d36c
to
d3bcf52
Compare