net: lib: aws_fota: Add single url option to job parser #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnawratil
requested review from
simensrostad,
jtguggedal,
coderbyheart and
carlescufi
as code owners
github-actions
bot
added
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
fnawratil
force-pushed
the
fota-single-url
branch
2 times, most recently
from
86df7b5
to
1b10382
Compare
github-actions
bot
removed
the
changelog-entry-required
fnawratil
force-pushed
the
fota-single-url
branch
2 times, most recently
from
efe33d8
to
f43063f
Compare
fnawratil
force-pushed
the
fota-single-url
branch
2 times, most recently
from
aede137
to
4bd87f9
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
fnawratil
force-pushed
the
fota-single-url
branch
6 times, most recently
from
4236189
to
2bc8ce0
Compare
wiba-nordic
requested changes
Aug 7, 2023
jtguggedal
reviewed
Aug 7, 2023
fnawratil
force-pushed
the
fota-single-url
branch
2 times, most recently
from
ec8c587
to
2af4c7b
Compare
simensrostad
reviewed
Aug 7, 2023
fnawratil
force-pushed
the
fota-single-url
branch
from
2af4c7b
to
990d3cd
Compare
Previously the AWS FOTA job parser only supported passing firmware update URLs using split hostname and path fields. Now a combined URL field is supported alternatively. This is required for presigned AWS S3 URLs. Additionally the maximum lengths for the host and file path are now passed from the caller to the job parser. Co-authored-by: Joshua Crawford <joshua.crawford@levno.com> Signed-off-by: Fabian Nawratil <fabian.nawratil@nordicsemi.no>
fnawratil
force-pushed
the
fota-single-url
branch
from
990d3cd
to
e9e21f6
Compare
simensrostad
approved these changes
Aug 7, 2023
wiba-nordic
approved these changes
Aug 8, 2023
jtguggedal
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the AWS FOTA job parser only supported passing firmware update URLs using split hostname and path fields.
Now a combined URL field is supported alternatively.
This is required for presigned AWS S3 URLs.
Additionally the maximum lengths for the parsed hostname and file path are now given as parameters.