applications: nrf_desktop: Fix returning error in MCUmgr callbacks #11964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change fixes returning error in MCUmgr callbacks. This prevents assertion failures when the error is returned by the application module. Jira: NCSDK-22964 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
github-actions
bot
added
the
changelog-entry-required
MarekPieta
added
10-min-review
and removed
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
kapi-no
approved these changes
Aug 7, 2023
mkapala-nordic
approved these changes
Aug 7, 2023
No, the MCUmgr API was changed after NCS 2.4.0. Then I think no doc update is needed here (the module is even marked as experimental currently). |
nordicjm
reviewed
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change fixes returning error in MCUmgr callbacks. This prevents assertion failures when the error is returned by the application module.
Jira: NCSDK-22964