net: lib: aws_fota: Improve error handling for FOTA jobs #11995
Merged
+165
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
fnawratil
requested review from
simensrostad,
jtguggedal and
coderbyheart
as code owners
fnawratil
force-pushed
the
fota-error-handling
branch
from
534908b
to
cee258e
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
fnawratil
force-pushed
the
fota-error-handling
branch
2 times, most recently
from
049c480
to
bd2739f
Compare
github-actions
bot
added
doc-required
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
fnawratil
force-pushed
the
fota-error-handling
branch
2 times, most recently
from
b03d3a6
to
47fa2a9
Compare
jtguggedal
reviewed
Aug 16, 2023
fnawratil
force-pushed
the
fota-error-handling
branch
from
47fa2a9
to
3dc82f0
Compare
fnawratil
force-pushed
the
fota-error-handling
branch
from
3dc82f0
to
8eea68c
Compare
jtguggedal
approved these changes
Aug 17, 2023
divipillai
approved these changes
Aug 17, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
Improves error handling by providing more fine grained errors on job parsing. Jobs are now marked as failed if document is invalid but the job id could be parsed. A new error state is introduced to enable retries for marking jobs as failed. Additionally, the job update accepted/rejected topics are now longer subscribed to, as this is not necessary to receive the respective messages and thus adds unnecessary overhead. Signed-off-by: Fabian Nawratil <fabian.nawratil@nordicsemi.no>
fnawratil
force-pushed
the
fota-error-handling
branch
from
8eea68c
to
e94d736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error handling by providing more fine grained errors on job parsing.
Jobs are now marked as failed if document is invalid but the job id could be parsed.
A new error state is introduced to enableretries for marking jobs as failed.
Additionally, the job update accepted/rejected topics are no longer subscribed to, as this is not necessary to receive the respective messages and thus adds unnecessary overhead.