Update nrf_cloud_rest_device_message sample to use CAF instead of DK library #12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
4b8d7bb
to
f5bfa19
Compare
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
f5bfa19
to
c65beb3
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
jayteemo
approved these changes
Aug 14, 2023
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
c65beb3
to
2d13bd1
Compare
plskeggs
approved these changes
Aug 16, 2023
| @@ -0,0 +1,60 @@ | |||
| /* Copyright (c) 2023 Nordic Semiconductor ASA | |||
There was a problem hiding this comment.
We need to add support for the 9161 to all our samples. I've created a ticket for it: https://nordicsemi.atlassian.net/browse/IRIS-6848.
When that happens, there will need to be an overlay for that as well here, I assume.
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
2d13bd1
to
bf380ef
Compare
tony-le-24
changed the title
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
glarsennordic
approved these changes
Aug 21, 2023
samples/cellular/nrf_cloud_rest_device_message/boards/nrf9160dk_nrf9160_ns.overlay
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_rest_device_message/boards/nrf9160dk_nrf9160_ns.overlay
Outdated
Show resolved
Hide resolved
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
bf380ef
to
1d58171
Compare
peknis
requested changes
Aug 22, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_rest_device_message/include/buttons_def.h
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_rest_device_message/include/buttons_def.h
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_rest_device_message/include/leds_def.h
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_rest_device_message/include/leds_def.h
Outdated
Show resolved
Hide resolved
Updated the sample to use CAF instead of DK library for led and button events. Added a device-tree overlay for LEDs to work with CAF LEDs module. Added header files for buttons and LEDs definition which are required by CAF. Also, added error message for when the sample fails to send alerts to nRF Cloud. Signed-off-by: Tony Le <tony.le@nordicsemi.no>
tony-le-24
force-pushed
the
update-rest-device-message-sample
branch
from
1d58171
to
0c7ae05
Compare
peknis
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the nrf_cloud_rest_device_message sample to use the Common Application Framework instead of DK library. Added DTS overlay for nrf9160dk_nrf9160_ns platform to have the LEDs compatible with CAF LED module.