Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Implemented bridge persistent storage module. #12032

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

kkasperczyk-no
Copy link
Contributor

Added a module that allows to persist information related to the Matter bridge in the storage:

  • Added persistent storage util that is a generic module that can be used to handle custom keys hierarchy in the various applications.
  • Created bridge storage manager that uses persistent storage util to describe data hierarchy of information stored for Matter bridge device.

This PR only adds a modules implementation that are not yet used by the Bridge application. The application will be modified in a follow-up PR, as it requires significant API refactor.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 14, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The persistent storage util looks very nice :)

Copy link
Contributor

@markaj-nordic markaj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, most comments are just nits.

samples/matter/common/src/persistent_storage_util.cpp Outdated Show resolved Hide resolved
samples/matter/common/src/persistent_storage_util.cpp Outdated Show resolved Hide resolved
samples/matter/common/src/bridge/bridged_device.h Outdated Show resolved Hide resolved
Added a module that allows to persist information related to the
Matter bridge in the storage:

* Added persistent storage util that is a generic module
that can be used to handle custom keys hierarchy in the
various applications.
* Created bridge storage manager that uses persistent storage
util to describe data hierarchy of information stored for
Matter bridge device.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
@LuDuda LuDuda merged commit 8d3d7b9 into nrfconnect:main Aug 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants