Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: peripheral_fast_pair: Disable CCC Lazy Loading to allow for rebond #12033

Merged
merged 1 commit into from
Aug 21, 2023
Merged

samples: peripheral_fast_pair: Disable CCC Lazy Loading to allow for rebond #12033

merged 1 commit into from
Aug 21, 2023

Conversation

alstrzebonski
Copy link
Contributor

Disabled CONFIG_BT_SETTINGS_CCC_LAZY_LOADING Kconfig option to workaround rebond issue related to NCSDK-22921 Zephyr bug.

Jira: NCSDK-22923

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Aug 14, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 14, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@alstrzebonski alstrzebonski changed the title samples: bluetooth: Fast Pair: Disable CCC Lazy Loading to allow for rebond samples: peripheral_fast_pair: Disable CCC Lazy Loading to allow for rebond Aug 16, 2023
@alstrzebonski
Copy link
Contributor Author

Addressed review comments. Please rereview.

@alstrzebonski
Copy link
Contributor Author

Applied review comments. Please rereview.

@alstrzebonski
samples: peripheral_fast_pair: Disable CCC Lazy Loading to allow for …
2b3c897 
…rebond

Disabled CONFIG_BT_SETTINGS_CCC_LAZY_LOADING Kconfig option to
workaround rebond issue related to NCSDK-22921 Zephyr bug.

Jira: NCSDK-22923

Signed-off-by: Aleksander Strzebonski <aleksander.strzebonski@nordicsemi.no>
@kapi-no
Copy link
Contributor

kapi-no commented Aug 18, 2023

Make sure to create a task for adding this known issue during the next release process. We already have a nice description for it so it will be just a matter of copy-paste operation.

@alstrzebonski
Copy link
Contributor Author

Make sure to create a task for adding this known issue during the next release process. We already have a nice description for it so it will be just a matter of copy-paste operation.

Done: https://nordicsemi.atlassian.net/browse/NCSDK-23124

@nordicjm nordicjm merged commit e8e9bfd into nrfconnect:main Aug 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapi-no kapi-no kapi-no approved these changes

@MarekPieta MarekPieta MarekPieta approved these changes

@divipillai divipillai divipillai approved these changes

@KAGA164 KAGA164 Awaiting requested review from KAGA164

@carlescufi carlescufi Awaiting requested review from carlescufi

@annwoj annwoj Awaiting requested review from annwoj

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alstrzebonski @NordicBuilder @kapi-no @MarekPieta @divipillai @nordicjm