Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Add state machine and forced scan state to BLE scan module #12107

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

MarekPieta
Copy link
Contributor

PR introduces:

  • a state machine to BLE scan module
  • forced scan state.
    In this state scanning is not interrupted by HID data transmission to host.
    The new state speeds up connection establishment e.g. after dongle boots.

Jira: NCSDK-20843

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 22, 2023
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 22, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 22, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
Change increases number of L2CAP TX buffers on dongles. This is needed
to use new scanning algorithm that allows to connect with next peer
before HID subscription is finished for the previously connected peer.

Jira: NCSDK-20843

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, I left a few comments

applications/nrf_desktop/src/modules/Kconfig.ble_scan Outdated Show resolved Hide resolved
applications/nrf_desktop/src/modules/ble_scan.c Outdated Show resolved Hide resolved
applications/nrf_desktop/src/modules/ble_scan.c Outdated Show resolved Hide resolved
applications/nrf_desktop/src/modules/ble_scan.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
Change introduces a state machine to BLE scan module.

Jira: NCSDK-20843

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Change introduces forced scan state. In this state scanning is not
interrupted by HID data transmission to host. The new state speeds up
connection establishment.

Jira: NCSDK-20843

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 23, 2023
Copy link
Contributor

@alstrzebonski alstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlubos rlubos merged commit 1ea0bd3 into nrfconnect:main Aug 23, 2023
14 checks passed
@MarekPieta MarekPieta deleted the ble_scan_pr2 branch August 24, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants