-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: nrf_desktop: Add state machine and forced scan state to BLE scan module #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 22, 2023
MarekPieta
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 22, 2023
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
MarekPieta
force-pushed
the
ble_scan_pr2
branch
from
August 23, 2023 05:32
c896f03
to
65f4036
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
MarekPieta
force-pushed
the
ble_scan_pr2
branch
from
August 23, 2023 05:55
65f4036
to
77950d2
Compare
MarekPieta
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
Change increases number of L2CAP TX buffers on dongles. This is needed to use new scanning algorithm that allows to connect with next peer before HID subscription is finished for the previously connected peer. Jira: NCSDK-20843 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta
force-pushed
the
ble_scan_pr2
branch
from
August 23, 2023 09:23
77950d2
to
f59f0c4
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
MarekPieta
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
kapi-no
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, I left a few comments
MarekPieta
force-pushed
the
ble_scan_pr2
branch
from
August 23, 2023 11:31
f59f0c4
to
46b5ac2
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
MarekPieta
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
kapi-no
approved these changes
Aug 23, 2023
Change introduces a state machine to BLE scan module. Jira: NCSDK-20843 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Change introduces forced scan state. In this state scanning is not interrupted by HID data transmission to host. The new state speeds up connection establishment. Jira: NCSDK-20843 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta
force-pushed
the
ble_scan_pr2
branch
from
August 23, 2023 12:57
46b5ac2
to
16c244c
Compare
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
MarekPieta
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Aug 23, 2023
alstrzebonski
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces:
In this state scanning is not interrupted by HID data transmission to host.
The new state speeds up connection establishment e.g. after dongle boots.
Jira: NCSDK-20843