Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issues do not report the parsed file #1

Open
nsensfel opened this issue Jul 19, 2020 · 4 comments
Open

Parsing issues do not report the parsed file #1

nsensfel opened this issue Jul 19, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@nsensfel
Copy link
Owner

Issues in parsing raised by ANTLR indicate messages looking like the following:

line 19:3 extraneous input '(variable' expecting {WS, AT_KW, PARAMETER_KW}
line 19:13 extraneous input 'oscar' expecting {WS, AT_KW, PARAMETER_KW}
<Java stack trace>

At no point is the file containing these lines indicated, making it difficult to locate the issue.

@nsensfel nsensfel added the bug Something isn't working label Jul 19, 2020
@nsensfel nsensfel self-assigned this Jul 19, 2020
@nsensfel
Copy link
Owner Author

nsensfel commented Aug 2, 2020

This should now be working properly.

@nsensfel nsensfel closed this as completed Aug 2, 2020
@nsensfel
Copy link
Owner Author

It has improved, but there are still cases where the location of the issue isn't pointed out in any other detail than the file in which it occurred. This isn't enough.

@nsensfel nsensfel reopened this Aug 30, 2020
@nsensfel
Copy link
Owner Author

nsensfel commented Nov 7, 2020

Example of case where the reported error doesn't help enough: writing (cond 42).

@nsensfel
Copy link
Owner Author

nsensfel commented Sep 4, 2021

Still an issue in 050e329. When the parser invalidates the input or when there is a Java error, it is still rather hard to figure out exactly what part of the narrative is causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant