Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binder? #399

Closed
jrbourbeau opened this issue Dec 5, 2023 · 3 comments · Fixed by #840
Closed

Remove binder? #399

jrbourbeau opened this issue Dec 5, 2023 · 3 comments · Fixed by #840

Comments

@jrbourbeau
Copy link
Collaborator

Each PR gets a comment like this one #397 (comment) with a binder link. Though it looks like the binder is build is broken (see this build for an example). I'll propose we remove the PR comments until the builds are fixed.

@MattF-NSIDC
Copy link

Good catch. I got so used to those comments that I stopped seeing them 🤣

@jhkennedy
Copy link
Collaborator

As of #821, Binder is working again, which begs the question do we want to re-enable the binder links?

I personally don't care either way, but I lean not re-enabling them and closing this issue.

@mfisher87
Copy link
Collaborator

I'd be pro re-enabling if they worked like the ReadTheDocs links work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants