-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple-point searches #491
Comments
Possibly related to #504 |
cc @Sherwin-14 |
@mfisher87 Hey, needed some clarity over this. I went through the |
Looking at #504 do we need to do a similar task ( improving polygon coordinate handling) as the OP suggested in the discussion? |
I suggest opening an enhancement request against python_cmr. That's where all such CMR search enhancement requests should be made first, because the ultimate goal is to remove all duplicate CMR search functionality from The reason we have duplicate functionality in We might still end up duplicating code here until |
earthaccess/earthaccess/search.py Lines 860 to 873 in be1ec48
This method only supports a single point currently, but we want to support any number of points to reach parity with the CMR API we're using under the hood. As chuck mentioned, the |
That means I might need to open up a feature request in python_cmr repo? I thought I should try there so maybe we can discuss the solution here and then open up a PR there? |
Technically, this method supports whatever It turns out that |
Maybe I'm missing something, but it looks to me like there's more to this. When |
No need to do that. You just need to be able to call |
In case you're wondering, yes, there are existing functions that behave in this manner, where you can call them multiple times to tack on additional values instead of overwriting a sole value. For example: https://github.com/nasa/python_cmr/blob/develop/cmr/queries.py#L396 |
I opened up a issue on |
Thanks all for the explanation and for the paperwork! :) |
💯 Awesome work getting this feature merged into python-cmr @Sherwin-14 and @chuckwondo! nasa/python_cmr#73 |
https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html#c-point
#490
The text was updated successfully, but these errors were encountered: