Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions migration #187

Closed
wants to merge 13 commits into from
Closed

Conversation

erickisos
Copy link
Contributor

@erickisos erickisos commented Jan 24, 2022

Status

DONE

Background context

Recently, the CircleCI process has stopped working, so now we need to evaluate alternatives to run our existing validations, this PR is intended to solve that problem by providing the basic tasks that we already had directly on Github Actions.

Relates to #185

Erick G. Islas-Osuna added 5 commits January 24, 2022 11:39
In order to keep this as a working project, we can recommend the usage of a pre-commit pipeline in order to just commit code which could be whithin our expectations of "code quality".
@erickisos erickisos marked this pull request as ready for review January 24, 2022 21:39
@erickisos erickisos requested a review from a team as a code owner January 24, 2022 21:39
scripts/create_venv.sh Outdated Show resolved Hide resolved
@erickisos
Copy link
Contributor Author

Just in case, the checks for this PR are running directly on Github Actions on my side, but after the merge is expected to have everything running here at the main repository.

You can check the results and steps here.

@erickisos
Copy link
Contributor Author

Update: Now we have the python3.9 version of the tests running here @caique-lima

However, maybe we can improve this in another PR by adding tox with multiple targets(?).

Copy link
Contributor

@prcastro prcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run: . scripts/create_venv.sh
- name: Init .pypirc
env:
PYPI_USER: ${{ secrets.PYPI_USER }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we set these secrets?

@fpingas
Copy link
Contributor

fpingas commented Mar 28, 2023

Closing as it was solved in #227

@fpingas fpingas closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants