-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions migration #187
Conversation
In order to keep this as a working project, we can recommend the usage of a pre-commit pipeline in order to just commit code which could be whithin our expectations of "code quality".
Also, add the usage of secrets as environment vars for tags.
Just in case, the checks for this PR are running directly on Github Actions on my side, but after the merge is expected to have everything running here at the main repository. You can check the results and steps here. |
Update: Now we have the python3.9 version of the tests running here @caique-lima However, maybe we can improve this in another PR by adding tox with multiple targets(?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run: . scripts/create_venv.sh | ||
- name: Init .pypirc | ||
env: | ||
PYPI_USER: ${{ secrets.PYPI_USER }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we set these secrets?
Closing as it was solved in #227 |
Status
DONE
Background context
Recently, the CircleCI process has stopped working, so now we need to evaluate alternatives to run our existing validations, this PR is intended to solve that problem by providing the basic tasks that we already had directly on Github Actions.
Relates to #185