Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate KFrag/CFrag proofs from their respective objects? #4

Open
fjarri opened this issue Aug 5, 2020 · 3 comments
Open

Separate KFrag/CFrag proofs from their respective objects? #4

fjarri opened this issue Aug 5, 2020 · 3 comments
Labels
ABI Changes the format of serialized objects API Related to public API enhancement New feature or request
Milestone

Comments

@fjarri
Copy link
Contributor

fjarri commented Aug 5, 2020

This will mean that one can create/use non-verified kfrags/cfrags, which may be useful in performance-critical environments where one needs to process many objects from the same source, and chooses to only check some of them (some kind of streaming service, perhaps?).

@fjarri fjarri added enhancement New feature or request cryptography Needs attention of someone who knows what they're doing labels Aug 5, 2020
@tuxxy
Copy link

tuxxy commented Aug 12, 2020

This is a solid issue.
I think this gestures towards a larger refactor of (both) Umbral implementations so that the API is a bit more pristine. PyUmbral is a solid reference at the moment due to how stable it is, but the current goal (at least from my perspective) is to replace it with a Python wrapper around this one. So it makes sense to identify sensical refactor targets like the proofs, but there are many others that we can do as well.

@fjarri fjarri added the API Related to public API label Nov 29, 2020
@cygnusv
Copy link
Member

cygnusv commented Apr 7, 2021

I think that's fine. Initially they were separated, if I recall correctly. There's even a flag provide_proof for the reencryption function, so it makes sense.

@fjarri
Copy link
Contributor Author

fjarri commented Apr 7, 2021

There was a flag, but it was never used, that's why I joined them in this implementation. But now I'm wondering if they're worth splitting. This will change the API, so we need to decide sooner rather than later, I want to keep all the API breaking possible in this version.

@fjarri fjarri added this to the v0.1.0 milestone Apr 7, 2021
@fjarri fjarri removed the cryptography Needs attention of someone who knows what they're doing label Apr 19, 2021
@fjarri fjarri modified the milestones: v0.2.0, v1.0.0 Jun 13, 2021
@fjarri fjarri added the ABI Changes the format of serialized objects label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI Changes the format of serialized objects API Related to public API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants