Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it impossible to create less than threshold kfrags in generate_kfrags()? #48

Open
fjarri opened this issue May 19, 2021 · 2 comments
Open

Make it impossible to create less than threshold kfrags in generate_kfrags()? #48

fjarri opened this issue May 19, 2021 · 2 comments
Labels
API Related to public API
Milestone
v1.0.0

Comments

@fjarri
Copy link
Contributor

fjarri commented May 19, 2021

Currently the user can supply num_kfrags < threshold, rendering the resulting kfrags useless. We can pass overhead (or some other name) instead of num_kfrags, and return threshold + overhead kfrags. If both threshold and overhead are unsigned, it will be impossible to create a set of useless kfrags.
@fjarri fjarri added the API Related to public API label May 19, 2021
@fjarri fjarri mentioned this issue May 19, 2021
Merged
@fjarri fjarri changed the title Make it impossible to create less than threshold kfrags in generate_kfrags() Make it impossible to create less than threshold kfrags in generate_kfrags()? May 19, 2021
@fjarri fjarri added this to the v1.0.0 milestone Jun 13, 2021
@fjarri fjarri mentioned this issue Aug 19, 2021
Merged
@fjarri
Copy link
Contributor Author

fjarri commented Aug 20, 2021

Following the discussion in nucypher/nucypher#2774, we're renaming num_kfrags to shares instead, while keeping the relation between it and threshold.

@fjarri fjarri mentioned this issue Sep 4, 2021
Merged
@fjarri
Copy link
Contributor Author

fjarri commented Dec 30, 2021

This is related to #85 - should we just panic if threshold > shares?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Related to public API
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri