Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a less restrictive Provider type in retrieveAndDecrypt. #296

Closed
jdbertron opened this issue Sep 10, 2023 · 2 comments
Closed

Comments

@jdbertron
Copy link

Can we make the type less restrictive for the provider in retrieveAndDecrypt() ?
public async retrieveAndDecrypt( provider: ethers.providers.Web3Provider, conditionExpr: ConditionExpression, variant: FerveoVariant, ciphertext: Ciphertext ): Promise<Uint8Array> {

Not everyone will use a Web interface and Wallet to connect. I'm using it within a node.js application and a JsonRpcProvider.
Using ethers it's probably OK to just use the generic Provider interface.

@piotr-roslaniec
Copy link
Contributor

Hi @jdbertron, we've switched to a more permissive provider type, ethers.providers.Provider, in this PR: https://github.com/nucypher/nucypher-ts/pull/270/files#diff-aea7a7ec89768972146f36cc3bc087e392dffdccbe6cde4790183ae3ed77de92R48-R49

These changes will be available in the next alpha release.

@piotr-roslaniec
Copy link
Contributor

Fixed by #270, pending release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants