Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitRepository.HttpsUrl is wrong when hosted in Azure DevOps #1393

Open
ChristophLindemann opened this issue Jun 18, 2024 · 0 comments
Open

GitRepository.HttpsUrl is wrong when hosted in Azure DevOps #1393

ChristophLindemann opened this issue Jun 18, 2024 · 0 comments
Labels
bug

Comments

@ChristophLindemann
Copy link

Usage Information

8

Description

When a git repo is hosted in Azure DevOps, the HttpsUrl does not contain .git suffix.

The code in GitRepository is wrong, as it is hardcoded to expect the .git instead of reading origin from the git configuration

nuke/source/Nuke.Build/VCS/GitRepository.cs

Line 260 in 4bfee84

public string HttpsUrl => Endpoint != null ? $"https://{Endpoint}/{Identifier}.git" : null;

Reproduction Steps

Use a Azure DevOps repo

the url will be
HTTPS: https://Tenant@dev.azure.com/Tenant/TheProject/_git/this-is-my-repo
SSH: git@ssh.dev.azure.com:v3/Tenant/TheProject/this-is-my-repo

Expected Behavior

GitRepository.HttpsUrl should return "https://Tenant@dev.azure.com/Tenant/TheProject/_git/this-is-my-repo"

Actual Behavior

GitRepository.HttpsUrl actually return "https://dev.azure.com/Tenant/TheProject/_git/this-is-my-repo.git"

Regression?

No response

Known Workarounds

No response

Could you help with a pull-request?

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristophLindemann