Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar mistake #5858

Open
nus-se-bot opened this issue Nov 12, 2021 · 1 comment
Open

Grammar mistake #5858

nus-se-bot opened this issue Nov 12, 2021 · 1 comment

Comments

@nus-se-bot
Copy link

nus-se-bot commented Nov 12, 2021

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



image.png

Consistency in oxford commas. When listing an item with more than 3 elements you either add a comma before the "and" for the last element or you don't add a comma. It is fine either way, but it should be consistent.

"I like apples, oranges, and bananas."

vs

"I like apples, oranges and bananas."


[original: nus-cs2103-AY2122S1/pe-interim#5843] [original labels: severity.VeryLow type.DocumentationBug]
@luayida99
Copy link
Contributor

Team's Response

To our knowledge, there is no clear consensus on whether serial commas need to be there or not. We understand the issue is about consistency since serial comma appears in one line but not in the other. However, we did this on purpose to make the sentences sound more natural. Thus, we do not think this warrants a documentation bug.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants