Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit still succeeds even when no changes are made #5594

Open
nus-se-script opened this issue Apr 19, 2024 · 1 comment
Open

Edit still succeeds even when no changes are made #5594

nus-se-script opened this issue Apr 19, 2024 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Apr 19, 2024

image.png

Description

If I call the edit command without changing anything, success message is still returned

Steps to reproduce

  1. Launch the application for the first time to load initial data.
  2. Run edit command, set the name as the same

Expected behaviour

There should be an error message to warn me that no edits were made

Actual behaviour

No warnings were made, and the success message is displayed

Reason for severity

very minor flaw for users


[original: nus-cs2103-AY2324S2/pe-interim#5593] [original labels: type.FunctionalityBug severity.VeryLow]
@zoebelle-pang
Copy link
Contributor

zoebelle-pang commented Apr 20, 2024

Team's Response

Thanks for sharing your feedback on this. This seems to be more of a FeatureFlaw than a Functionality bug as the edit command is working as intended. After considering this, we still believe that adding a warning message specifically for 'no edit made' for the 'edit' command might not be essential compared to warning messages meant for 'delete' and 'clear' commands that affect data removal or reset. The edit function typically involves minor changes that users expect to make without additional alerts. Additionally, the edited information will be shown in the output message as shown in the image you've provided which users can check the changes made.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants