Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Using this project #15

Closed
alexandesigner opened this issue Jan 31, 2018 · 11 comments
Closed

[Question] Using this project #15

alexandesigner opened this issue Jan 31, 2018 · 11 comments

Comments

@alexandesigner
Copy link

alexandesigner commented Jan 31, 2018

Today to use this repository it is necessary to make a clone, why not add it to vue-cli so that users can only start it with vue init nuxt-community/electron-template <folder>, there is some restriction so you have not done so?

If it is the case I can send a PR with the changes

This question is available on Nuxt.js community (#c11)
@fredgig
Copy link

fredgig commented Mar 28, 2018

Attempting to npm run dev this template will cause an error (electron-userland/electron-compile#287). Apparently, using electron-webpack instead of electron-compile resolves the error according to the following issue:

Gum-Joe/tara#10

If possible, please keep this template up to date by utilizing webpacks!

@HoraceKeung
Copy link
Contributor

Have a look at this https://github.com/HoraceKeung/nuxtron

@alexandesigner
Copy link
Author

@HoraceKeung How cool, if you need any help to keep it, please let me know .. Maybe this repository can be merged with this, what do you think? @pi0

@HoraceKeung
Copy link
Contributor

Thanks, I would love to contribute to this repo. As I have mentioned in https://nuxtjs.cmty.io/nuxt-community/electron-template/issues/c14, there are differences that has to be taken into consideration.

@detrohutt
Copy link
Collaborator

@HoraceKeung @alexandesigner I originally created this repo but "officially" stepped down as maintainer quite a while ago because I'm no longer using nuxt in my personal project (which takes up all my time). So I've been "out of the loop" for a long time and I'm not familiar with any of the changes that would be needed to update this repo, but I still have write access. If you guys can put together a pull request and test that it doesn't break any current behavior, I'll merge it.

@HoraceKeung
Copy link
Contributor

@detrohutt I was trying to push a new branch but I may not have the permission.

@detrohutt
Copy link
Collaborator

@HoraceKeung You'll need to fork this repo, edit your fork with the necessary changes, and then open a pull request pointing to your fork.

@HoraceKeung
Copy link
Contributor

@detrohutt Thanks, just submitted a pull request.

@detrohutt
Copy link
Collaborator

Thanks! I'll review it later tonight and if everything looks good I'll merge it. If not, I'll let you know what needs changing.

@detrohutt
Copy link
Collaborator

detrohutt commented Apr 12, 2018

Nuxtron has been merged with this repo. The original version of electron-template is available on the git-clone branch.

@alexandesigner
Copy link
Author

Awesome @detrohutt, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants