Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never option on tab warning isn't "sticky" #203

Open
stretch327 opened this issue Jan 3, 2024 · 7 comments
Open

Never option on tab warning isn't "sticky" #203

stretch327 opened this issue Jan 3, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@stretch327
Copy link

When you first open a groovy file and get the warning that says:

"CodeNarc linter doesn't like tabs, let's replace them by spaces ?"

The options that are available are "Always, Yes, No and Never"

If you select Never, it is treated as if you clicked "No" and you still have to answer this question again each time you open a new document.

@stretch327
Copy link
Author

Stale because you haven't looked at it?

@nvuillam
Copy link
Owner

@stretch327 indeed !

We are mostly 2 persons ( @stevenh and myself ) to maintain vscode-groovy-lint for free, and our available time is limited... sometimes it can take time :/

Maybe you'd like to help by submitting a pull request with a fix ?

@stevenh
Copy link
Collaborator

stevenh commented Feb 12, 2024

Never is currently acting as no for this session vs never ask me again, what's the intended behaviour here?

@nvuillam
Copy link
Owner

@stevenh "Never again for any Groovy file i'll open with this vscode" ^^

I don't know if it's good or not, but it was the previous behaviour so people are probably used to it ^^

@stevenh
Copy link
Collaborator

stevenh commented Feb 13, 2024

Thanks for the confirmation. I can confirm it's only set in a session variable there is no configuration option I could find for that, let me know if I missed something @nvuillam .

If the above is correct, to fix we would need to introduce a config option for this and have the dialog option interact with that and the document handler subscribe to config updates, so a little bit involved.

@nvuillam
Copy link
Owner

@stevenh let's check how it was done before your refactoring :)
I think i wrote the option in vscode settings

@stretch327
Copy link
Author

Sounds like you guys have ideas how to fix it. Please keep this case open!

Repository owner deleted a comment from github-actions bot May 29, 2024
Repository owner deleted a comment from github-actions bot May 29, 2024
Repository owner deleted a comment from github-actions bot Jun 30, 2024
Repository owner deleted a comment from github-actions bot Jun 30, 2024
Repository owner deleted a comment from github-actions bot Jun 30, 2024
@stevenh stevenh added the bug Something isn't working label Jun 30, 2024
Repository owner deleted a comment from github-actions bot Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants