From e807f8cd95f5d62ffaa5ddcfb7b8e1944c03b705 Mon Sep 17 00:00:00 2001 From: Eric Slosser <325572+mr-fixit@users.noreply.github.com> Date: Mon, 31 Oct 2022 08:40:36 -0400 Subject: [PATCH] bump 5.0.8 (#359) --- .../contents.xcworkspacedata | 7 +++++ CHANGELOG.md | 2 ++ Documentation/Release Process.md | 18 ++++++----- NYTPhotoViewer.podspec | 2 +- bitrise.yml | 31 ------------------- 5 files changed, 20 insertions(+), 40 deletions(-) create mode 100644 .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata delete mode 100644 bitrise.yml diff --git a/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata b/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata new file mode 100644 index 00000000..919434a6 --- /dev/null +++ b/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata @@ -0,0 +1,7 @@ + + + + + diff --git a/CHANGELOG.md b/CHANGELOG.md index 855bbfe3..c02e07e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,5 @@ +## [5.0.8](https://github.com/nytimes/NYTPhotoViewer/releases/tag/5.0.8) + Changes for users of the library currently on `5.0.8`: - using metadata to add summary to share activity diff --git a/Documentation/Release Process.md b/Documentation/Release Process.md index cea5a468..4c2cdc1c 100644 --- a/Documentation/Release Process.md +++ b/Documentation/Release Process.md @@ -2,16 +2,18 @@ _While tagging a new version of a library and pushing it to CocoaPods is concept # NYTPhotoViewer Release Process -- Review [the diff between `master` and `develop`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop) to determine which part of the version number to increment, in accordance with [semantic versioning](http://semver.org/). +- Review the diff between `the last tag` and `develop` to determine which part of the version number to increment, in accordance with [semantic versioning](http://semver.org/). +- Create a branch off the commit in develop (probably HEAD) you wish to release. - Update [the Podspec](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/NYTPhotoViewer.podspec) to the new version number. - - Make this change via a pull request to trigger notifications for those who watch the repository. -- Using [the diff](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop), [the commit history](https://github.com/NYTimes/NYTPhotoViewer/commits/develop), and any notes about `develop` which may have been written in the `CHANGELOG`, update [`CHANGELOG.md`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md) with changes in the new version which may affect library users. +- Using the diff above and any notes about `develop` which may have been written in the `CHANGELOG`, update [`CHANGELOG.md`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md) with changes in the new version which may affect library users. - When reviewing the commit history, searching for “Merge pull request” helps find changes which should appear in [the `CHANGELOG`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md). -- Update any other documentation which still needs to be updated, given those changes. -- Create a pull request merging [`develop` into `master`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop). Merge it yourself, immediately. -- Create a [Github release](https://github.com/NYTimes/NYTPhotoViewer/releases), using the new version number (eg. `1.0.0`) as the tag, and the merge commit into `master` as the target. Copy [the `CHANGELOG`](https://raw.githubusercontent.com/NYTimes/NYTPhotoViewer/develop/CHANGELOG.md)’s Markdown content for this release into the Github release. -- Push the new Podspec to Cocoapods Trunk: `pod trunk push NYTPhotoViewer.podspec` - - Ensure your local clone is up-to-date before this push. +- Update any other documentation. +- Commit the above changes to your branch, suggested message "bump v" +- Create a pull request to merge your branch into `develop`. This will trigger notifications for those who watch the repository. +- Once that PR is merged: + - Create a [Github release](https://github.com/NYTimes/NYTPhotoViewer/releases), using the new version number (eg. `1.0.0`) as the tag, and the merge commit into `master` as the target. Copy [the `CHANGELOG`](https://raw.githubusercontent.com/NYTimes/NYTPhotoViewer/develop/CHANGELOG.md)’s Markdown content for this release into the Github release. + - Ensure your local clone is up-to-date on `develop` + - Push the new Podspec to Cocoapods Trunk: `pod trunk push NYTPhotoViewer.podspec`. ## CocoaPods Trunk Setup diff --git a/NYTPhotoViewer.podspec b/NYTPhotoViewer.podspec index ff868015..786240a8 100644 --- a/NYTPhotoViewer.podspec +++ b/NYTPhotoViewer.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "NYTPhotoViewer" - s.version = "5.0.7" + s.version = "5.0.8" s.description = <<-DESC NYTPhotoViewer is a slideshow and image viewer that includes double tap to zoom, captions, support for multiple images, interactive flick to dismiss, animated zooming presentation, and more. diff --git a/bitrise.yml b/bitrise.yml deleted file mode 100644 index 4e0928d8..00000000 --- a/bitrise.yml +++ /dev/null @@ -1,31 +0,0 @@ -format_version: "8" -default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git -project_type: ios -app: - envs: - - BITRISE_PROJECT_PATH: Examples/NYTPhotoViewer.xcworkspace - - BITRISE_SCHEME: Example - - BITRISE_SCHEME2: Example-Swift - - BITRISE_EXPORT_METHOD: development -trigger_map: -- pull_request_source_branch: '*' - workflow: primary -workflows: - primary: - steps: - - activate-ssh-key@4.0.3: - run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}' - - git-clone@4.0.17: {} - - cache-pull@2.1.1: {} - - certificate-and-profile-installer@1.10.1: {} - - cocoapods-install@1.9.1: {} - - xcode-test@2.4.1: - inputs: - - project_path: $BITRISE_PROJECT_PATH - - scheme: $BITRISE_SCHEME - - xcode-test@2.4.1: - inputs: - - project_path: $BITRISE_PROJECT_PATH - - scheme: $BITRISE_SCHEME2 - - deploy-to-bitrise-io@1.9.2: {} - - cache-push@2.2.1: {}