From 2f78e3778b1d87a7c6dcd94d1de743bfcb4ea1b9 Mon Sep 17 00:00:00 2001
From: Danny Willems <be.danny.willems@gmail.com>
Date: Fri, 1 Nov 2024 19:02:36 +0100
Subject: [PATCH] o1vm: remove old FIXME

---
 o1vm/src/pickles/prover.rs   | 1 -
 o1vm/src/pickles/tests.rs    | 3 +--
 o1vm/src/pickles/verifier.rs | 5 ++---
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/o1vm/src/pickles/prover.rs b/o1vm/src/pickles/prover.rs
index ebafbb695a..2f40787546 100644
--- a/o1vm/src/pickles/prover.rs
+++ b/o1vm/src/pickles/prover.rs
@@ -254,7 +254,6 @@ where
         // We compute the polynomial t(X) by dividing the constraints polynomial
         // by the vanishing polynomial, i.e. Z_H(X).
         let (quotient, rem) = expr_evaluation_interpolated
-            // FIXME: Should this be d8?
             .divide_by_vanishing_poly(domain.d1)
             .unwrap_or_else(fail_final_q_division);
         // As the constraints must be verified on H, the rest of the division
diff --git a/o1vm/src/pickles/tests.rs b/o1vm/src/pickles/tests.rs
index 422f10bc13..873609d604 100644
--- a/o1vm/src/pickles/tests.rs
+++ b/o1vm/src/pickles/tests.rs
@@ -111,8 +111,7 @@ fn test_small_circuit() {
     .unwrap();
 
     let instant_before_verification = Instant::now();
-    let verif =
-        verify::<Pallas, BaseSponge, ScalarSponge>(domain, &srs, &vec![expr.clone()], &proof);
+    let verif = verify::<Pallas, BaseSponge, ScalarSponge>(domain, &srs, &[expr.clone()], &proof);
     let instant_after_verification = Instant::now();
     debug!(
         "Verification took: {} ms",
diff --git a/o1vm/src/pickles/verifier.rs b/o1vm/src/pickles/verifier.rs
index b57b9a6422..9057a89802 100644
--- a/o1vm/src/pickles/verifier.rs
+++ b/o1vm/src/pickles/verifier.rs
@@ -69,8 +69,7 @@ pub fn verify<
 >(
     domain: EvaluationDomains<G::ScalarField>,
     srs: &<OpeningProof<G> as OpenProof<G>>::SRS,
-    //FIXME: change vec to array
-    constraints: &Vec<E<G::ScalarField>>,
+    constraints: &[E<G::ScalarField>],
     proof: &Proof<G>,
 ) -> bool
 where
@@ -177,7 +176,7 @@ where
     };
 
     let combined_expr =
-        Expr::combine_constraints(0..(constraints.len() as u32), constraints.clone());
+        Expr::combine_constraints(0..(constraints.len() as u32), constraints.to_vec());
 
     let numerator_zeta = PolishToken::evaluate(
         combined_expr.to_polish().as_slice(),