From 520bd77bab29301b6ddd5a043eb3e075af403971 Mon Sep 17 00:00:00 2001
From: Danny Willems <be.danny.willems@gmail.com>
Date: Mon, 25 Nov 2024 15:22:47 +0100
Subject: [PATCH] o1vm/riscv32im: test decoding sub

---
 o1vm/src/interpreters/riscv32im/tests.rs | 36 ++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/o1vm/src/interpreters/riscv32im/tests.rs b/o1vm/src/interpreters/riscv32im/tests.rs
index 5a322278d8..9042b3425a 100644
--- a/o1vm/src/interpreters/riscv32im/tests.rs
+++ b/o1vm/src/interpreters/riscv32im/tests.rs
@@ -43,6 +43,29 @@ pub fn generate_random_add_instruction<RNG: RngCore + CryptoRng>(rng: &mut RNG)
     ]
 }
 
+pub fn generate_random_sub_instruction<RNG: RngCore + CryptoRng>(rng: &mut RNG) -> [u8; 4] {
+    let opcode = 0b0110011;
+    let rd = rng.gen_range(0..32);
+    let funct3 = 0b000;
+    let rs1 = rng.gen_range(0..32);
+    let rs2 = rng.gen_range(0..32);
+    let funct2 = 0b00;
+    let funct5 = 0b01000;
+    let instruction = opcode
+        | (rd << 7)
+        | (funct3 << 12)
+        | (rs1 << 15)
+        | (rs2 << 20)
+        | (funct2 << 25)
+        | (funct5 << 27);
+    [
+        instruction as u8,
+        (instruction >> 8) as u8,
+        (instruction >> 16) as u8,
+        (instruction >> 24) as u8,
+    ]
+}
+
 #[test]
 pub fn test_instruction_decoding_add() {
     let mut env: Env<Fp> = dummy_env();
@@ -55,3 +78,16 @@ pub fn test_instruction_decoding_add() {
     let (opcode, _instruction) = env.decode_instruction();
     assert_eq!(opcode, Instruction::RType(RInstruction::Add));
 }
+
+#[test]
+pub fn test_instruction_decoding_sub() {
+    let mut env: Env<Fp> = dummy_env();
+    let mut rng = o1_utils::tests::make_test_rng(None);
+    let instruction = generate_random_sub_instruction(&mut rng);
+    env.memory[0].1[0] = instruction[0];
+    env.memory[0].1[1] = instruction[1];
+    env.memory[0].1[2] = instruction[2];
+    env.memory[0].1[3] = instruction[3];
+    let (opcode, _instruction) = env.decode_instruction();
+    assert_eq!(opcode, Instruction::RType(RInstruction::Sub));
+}