Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-393] Store the algorithm breakdown time into a specific file. #394

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions mllib-dal/src/main/native/Communicator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,47 +21,29 @@

#include "oneapi/ccl.hpp"
#include "oneapi/dal/detail/ccl/communicator.hpp"
#include "Singleton.hpp"

namespace de = oneapi::dal::detail;
namespace oneapi::dal::preview::spmd {

namespace backend {
struct ccl {};
} // namespace backend
class ccl_info {
friend class de::singleton<ccl_info>;

private:
ccl_info(int size, int rankId, ccl::shared_ptr_class<ccl::kvs> keyvs) {
rank = rankId;
rank_count = size;
kvs = keyvs;
}

public:
ccl::shared_ptr_class<ccl::kvs> kvs;
int rank;
int rank_count;
};

template <typename Backend>
communicator<device_memory_access::none> make_communicator(int size, int rank, const ccl::shared_ptr_class<ccl::kvs> kvs) {
auto& info = de::singleton<ccl_info>::get(size, rank, kvs);
// integral cast
return oneapi::dal::detail::ccl_communicator<device_memory_access::none>{ info.kvs,
info.rank,
info.rank_count };
return oneapi::dal::detail::ccl_communicator<device_memory_access::none>{ kvs,
rank,
size };
}

template <typename Backend>
communicator<device_memory_access::usm> make_communicator(sycl::queue& queue, int size, int rank, const ccl::shared_ptr_class<ccl::kvs> kvs) {
auto& info = de::singleton<ccl_info>::get(size, rank, kvs);
return oneapi::dal::detail::ccl_communicator<device_memory_access::usm>{
queue,
info.kvs,
oneapi::dal::detail::integral_cast<std::int64_t>(info.rank),
oneapi::dal::detail::integral_cast<std::int64_t>(info.rank_count)
kvs,
oneapi::dal::detail::integral_cast<std::int64_t>(rank),
oneapi::dal::detail::integral_cast<std::int64_t>(size)
};
}

Expand Down
68 changes: 40 additions & 28 deletions mllib-dal/src/main/native/CorrelationImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,33 +151,49 @@ static void doCorrelationDaalCompute(JNIEnv *env, jobject obj, size_t rankId,
static void doCorrelationOneAPICompute(
JNIEnv *env, jlong pNumTabData, jlong numRows, jlong numCols,
preview::spmd::communicator<preview::spmd::device_memory_access::usm> comm,
jobject resultObj) {
std::string breakdown_name, jobject resultObj) {
logger::println(logger::INFO, "oneDAL (native): GPU compute start");
const bool isRoot = (comm.get_rank() == ccl_root);
auto t1 = std::chrono::high_resolution_clock::now();
homogen_table htable = *reinterpret_cast<homogen_table *>(
createHomogenTableWithArrayPtr(pNumTabData, numRows, numCols,
comm.get_queue())
.get());
auto t2 = std::chrono::high_resolution_clock::now();
auto duration =
(float)std::chrono::duration_cast<std::chrono::milliseconds>(t2 - t1)
.count();
logger::println(
logger::INFO,
"Correlation batch(native): create homogen table took %f secs",
duration / 1000);

logger::Logger::getInstance(breakdown_name)
.printLogToFile("rankID was %d, create homogen table took %f secs.",
comm.get_rank(), duration / 1000);

const auto cor_desc =
covariance_gpu::descriptor<GpuAlgorithmFPType>{}.set_result_options(
covariance_gpu::result_options::cor_matrix |
covariance_gpu::result_options::means);
auto t1 = std::chrono::high_resolution_clock::now();
t1 = std::chrono::high_resolution_clock::now();
const auto result_train = preview::compute(comm, cor_desc, htable);
if (isRoot) {
logger::println(logger::INFO, "Mean:");
printHomegenTable(result_train.get_means());
logger::println(logger::INFO, "Correlation:");
printHomegenTable(result_train.get_cor_matrix());
auto t2 = std::chrono::high_resolution_clock::now();
auto duration =
t2 = std::chrono::high_resolution_clock::now();
duration =
std::chrono::duration_cast<std::chrono::milliseconds>(t2 - t1)
.count();
logger::println(
logger::INFO,
"Correlation batch(native): computing step took %d secs.",
duration / 1000);
logger::Logger::getInstance(breakdown_name)
.printLogToFile("rankID was %d, training step took %f secs.",
comm.get_rank(), duration / 1000);
// Return all covariance & mean
jclass clazz = env->GetObjectClass(resultObj);

Expand All @@ -197,19 +213,20 @@ static void doCorrelationOneAPICompute(

JNIEXPORT jlong JNICALL
Java_com_intel_oap_mllib_stat_CorrelationDALImpl_cCorrelationTrainDAL(
JNIEnv *env, jobject obj, jlong pNumTabData, jlong numRows, jlong numCols,
jint executorNum, jint executorCores, jint computeDeviceOrdinal,
jintArray gpuIdxArray, jobject resultObj) {
JNIEnv *env, jobject obj, jint rank, jlong pNumTabData, jlong numRows,
jlong numCols, jint executorNum, jint executorCores,
jint computeDeviceOrdinal, jintArray gpuIdxArray, jstring ip_port,
jstring breakdown_name, jobject resultObj) {
logger::println(logger::INFO,
"oneDAL (native): use DPC++ kernels; device %s",
ComputeDeviceString[computeDeviceOrdinal].c_str());

ccl::communicator &cclComm = getComm();
int rankId = cclComm.rank();
ComputeDevice device = getComputeDeviceByOrdinal(computeDeviceOrdinal);
switch (device) {
case ComputeDevice::host:
case ComputeDevice::cpu: {
ccl::communicator &cclComm = getComm();
int rankId = cclComm.rank();
NumericTablePtr pData = *((NumericTablePtr *)pNumTabData);
// Set number of threads for oneDAL to use for each rank
services::Environment::getInstance()->setNumberOfThreads(executorCores);
Expand All @@ -225,26 +242,21 @@ Java_com_intel_oap_mllib_stat_CorrelationDALImpl_cCorrelationTrainDAL(
}
#ifdef CPU_GPU_PROFILE
case ComputeDevice::gpu: {
int nGpu = env->GetArrayLength(gpuIdxArray);
logger::println(
logger::INFO,
"oneDAL (native): use GPU kernels with %d GPU(s) rankid %d", nGpu,
rankId);

jint *gpuIndices = env->GetIntArrayElements(gpuIdxArray, 0);

int size = cclComm.size();

auto queue =
getAssignedGPU(device, cclComm, size, rankId, gpuIndices, nGpu);

ccl::shared_ptr_class<ccl::kvs> &kvs = getKvs();
auto comm =
preview::spmd::make_communicator<preview::spmd::backend::ccl>(
queue, size, rankId, kvs);
logger::println(logger::INFO,
"oneDAL (native): use GPU kernels with rankid %d",
rank);

const char *str = env->GetStringUTFChars(ip_port, nullptr);
ccl::string ccl_ip_port(str);
const char *cstr = env->GetStringUTFChars(breakdown_name, nullptr);
std::string c_breakdown_name(cstr);
auto comm = createDalCommunicator(executorNum, rank, ccl_ip_port,
c_breakdown_name);
doCorrelationOneAPICompute(env, pNumTabData, numRows, numCols, comm,
resultObj);
env->ReleaseIntArrayElements(gpuIdxArray, gpuIndices, 0);
c_breakdown_name, resultObj);

env->ReleaseStringUTFChars(ip_port, str);
env->ReleaseStringUTFChars(breakdown_name, cstr);
break;
}
#endif
Expand Down
70 changes: 44 additions & 26 deletions mllib-dal/src/main/native/DecisionForestClassifierImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,11 @@ static jobject doRFClassifierOneAPICompute(
jdouble minImpurityDecreaseSplitNode, jint maxTreeDepth, jlong seed,
jint maxBins, jboolean bootstrap,
preview::spmd::communicator<preview::spmd::device_memory_access::usm> comm,
jobject resultObj) {
std::string breakdown_name, jobject resultObj) {
logger::println(logger::INFO, "oneDAL (native): GPU compute start");
const bool isRoot = (comm.get_rank() == ccl_root);

auto t1 = std::chrono::high_resolution_clock::now();
homogen_table hFeaturetable = *reinterpret_cast<homogen_table *>(
createHomogenTableWithArrayPtr(pNumTabFeature, featureRows, featureCols,
comm.get_queue())
Expand All @@ -227,6 +229,17 @@ static jobject doRFClassifierOneAPICompute(
createHomogenTableWithArrayPtr(pNumTabLabel, featureRows, labelCols,
comm.get_queue())
.get());
auto t2 = std::chrono::high_resolution_clock::now();
auto duration =
(float)std::chrono::duration_cast<std::chrono::milliseconds>(t2 - t1)
.count();
logger::println(
logger::INFO,
"DF Classifier (native): create feature homogen table took %f secs",
duration / 1000);
logger::Logger::getInstance(breakdown_name)
.printLogToFile("rankID was %d, create homogen table took %f secs.",
comm.get_rank(), duration / 1000);

const auto df_desc =
df::descriptor<GpuAlgorithmFPType, df::method::hist,
Expand All @@ -247,6 +260,7 @@ static jobject doRFClassifierOneAPICompute(
.set_max_tree_depth(maxTreeDepth)
.set_max_bins(maxBins);

t1 = std::chrono::high_resolution_clock::now();
const auto result_train =
preview::train(comm, df_desc, hFeaturetable, hLabeltable);
const auto result_infer =
Expand All @@ -261,6 +275,16 @@ static jobject doRFClassifierOneAPICompute(
printHomegenTable(result_infer.get_responses());
logger::println(logger::INFO, "Probabilities results:\n");
printHomegenTable(result_infer.get_probabilities());
t2 = std::chrono::high_resolution_clock::now();
duration = (float)std::chrono::duration_cast<std::chrono::milliseconds>(
t2 - t1)
.count();
logger::println(logger::INFO,
"DF Classifier (native): training step took %f secs.",
duration / 1000);
logger::Logger::getInstance(breakdown_name)
.printLogToFile("rankID was %d, training step took %f secs.",
comm.get_rank(), duration / 1000);

// convert to java hashmap
trees = collect_model(env, result_train.get_model(), classCount);
Expand Down Expand Up @@ -300,46 +324,40 @@ static jobject doRFClassifierOneAPICompute(
*/
JNIEXPORT jobject JNICALL
Java_com_intel_oap_mllib_classification_RandomForestClassifierDALImpl_cRFClassifierTrainDAL(
JNIEnv *env, jobject obj, jlong pNumTabFeature, jlong featureRows,
jlong featureCols, jlong pNumTabLabel, jlong labelCols, jint executorNum,
jint computeDeviceOrdinal, jint classCount, jint treeCount,
jint numFeaturesPerNode, jint minObservationsLeafNode,
JNIEnv *env, jobject obj, jint rank, jlong pNumTabFeature,
jlong featureRows, jlong featureCols, jlong pNumTabLabel, jlong labelCols,
jint executorNum, jint computeDeviceOrdinal, jint classCount,
jint treeCount, jint numFeaturesPerNode, jint minObservationsLeafNode,
jint minObservationsSplitNode, jdouble minWeightFractionLeafNode,
jdouble minImpurityDecreaseSplitNode, jint maxTreeDepth, jlong seed,
jint maxBins, jboolean bootstrap, jintArray gpuIdxArray,
jobject resultObj) {
jint maxBins, jboolean bootstrap, jintArray gpuIdxArray, jstring ip_port,
jstring breakdown_name, jobject resultObj) {
logger::println(logger::INFO, "oneDAL (native): use DPC++ kernels");

ccl::communicator &cclComm = getComm();
int rankId = cclComm.rank();
ComputeDevice device = getComputeDeviceByOrdinal(computeDeviceOrdinal);
switch (device) {
case ComputeDevice::gpu: {
int nGpu = env->GetArrayLength(gpuIdxArray);
logger::println(
logger::INFO,
"oneDAL (native): use GPU kernels with %d GPU(s) rankid %d", nGpu,
rankId);

jint *gpuIndices = env->GetIntArrayElements(gpuIdxArray, 0);
logger::println(logger::INFO,
"oneDAL (native): use GPU kernels with rankid %d",
rank);

int size = cclComm.size();
ComputeDevice device = getComputeDeviceByOrdinal(computeDeviceOrdinal);
const char *str = env->GetStringUTFChars(ip_port, nullptr);
ccl::string ccl_ip_port(str);
const char *cstr = env->GetStringUTFChars(breakdown_name, nullptr);
std::string c_breakdown_name(cstr);
auto comm = createDalCommunicator(executorNum, rank, ccl_ip_port,
c_breakdown_name);

auto queue =
getAssignedGPU(device, cclComm, size, rankId, gpuIndices, nGpu);

ccl::shared_ptr_class<ccl::kvs> &kvs = getKvs();
auto comm =
preview::spmd::make_communicator<preview::spmd::backend::ccl>(
queue, size, rankId, kvs);
jobject hashmapObj = doRFClassifierOneAPICompute(
env, pNumTabFeature, featureRows, featureCols, pNumTabLabel,
labelCols, executorNum, computeDeviceOrdinal, classCount, treeCount,
numFeaturesPerNode, minObservationsLeafNode,
minObservationsSplitNode, minWeightFractionLeafNode,
minImpurityDecreaseSplitNode, maxTreeDepth, seed, maxBins,
bootstrap, comm, resultObj);
bootstrap, comm, c_breakdown_name, resultObj);

env->ReleaseStringUTFChars(ip_port, str);
env->ReleaseStringUTFChars(breakdown_name, cstr);
return hashmapObj;
}
default: {
Expand Down
Loading
Loading