Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the failed UT on update branch #418

Open
zhouyuan opened this issue Oct 23, 2023 · 2 comments
Open

fix the failed UT on update branch #418

zhouyuan opened this issue Oct 23, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@zhouyuan
Copy link
Collaborator

Bug description

The following tests FAILED:
217 - velox_type_test (Failed)
225 - velox_expression_test (Failed)
227 - velox_dwio_common_test (Failed)
262 - velox_dwrf_e2e_filter_test (Failed)
282 - velox_functions_test (Failed)
284 - velox_functions_spark_aggregates_test (Failed)
288 - velox_hive_connector_test (Failed)
292 - velox_exec_test (Failed)

System information

n/a

Relevant logs

No response

@zhouyuan zhouyuan added the bug Something isn't working label Oct 23, 2023
@zhouyuan zhouyuan changed the title fix the failed on update branch fix the failed UT on update branch Oct 23, 2023
@surnaik
Copy link

surnaik commented Nov 2, 2023

@zhouyuan I do see a few other test suites failing
254 - velox_dwio_parquet_reader_test (SEGFAULT)
256 - velox_parquet_e2e_filter_test (SEGFAULT)
258 - velox_dwio_parquet_table_scan_test (Child aborted)

@zhouyuan
Copy link
Collaborator Author

zhouyuan commented Nov 3, 2023

@zhouyuan I do see a few other test suites failing 254 - velox_dwio_parquet_reader_test (SEGFAULT) 256 - velox_parquet_e2e_filter_test (SEGFAULT) 258 - velox_dwio_parquet_table_scan_test (Child aborted)

@surnaik thanks for reporting! indeed the failed the UTs are changing in daily rebase work.

  • The failures are due to patch & patch "conflicts" - as we merged 29 pending patches, however for each individual patch, the unit tests are actually passing.
  • In gluten we do make sure all Spark unit tests are passing w/ the daily rebase velox
  • as Meta team gradually merging the pending patches, all the unit tests should be "fixed" naturally

I'm still discussing with team to check for the best solution. Will keep update here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants