From 3336498d1169832e4d21ba70699b5e5d2faa9505 Mon Sep 17 00:00:00 2001 From: Emmanuelle Vargas-Gonzalez Date: Thu, 2 Jul 2020 12:57:45 -0400 Subject: [PATCH] minor tweaks to tests, missing assertion statements --- medallion/test/test_backends.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/medallion/test/test_backends.py b/medallion/test/test_backends.py index bd506e80..9d1a587a 100644 --- a/medallion/test/test_backends.py +++ b/medallion/test/test_backends.py @@ -108,7 +108,7 @@ def test_get_objects(backend): 'marking-definition--34098fce-860f-48ae-8e50-ebd3cc5e41da', 'malware--c0931cc6-c75e-47e5-9036-78fabc95d4ec', 'indicator--6770298f-0fd8-471a-ab8c-1c658a46574e'] - x = 0 + for x in range(0, len(correct_order)): assert objs['objects'][x]['id'] == correct_order[x] @@ -241,7 +241,7 @@ def test_get_object_manifests(backend): assert r.headers['X-TAXII-Date-Added-Last'] == "2017-12-31T13:49:53.935000Z" # checking ordered by date_added - x = 1 + for x in range(1, len(manifests["objects"])): assert manifests["objects"][x - 1]["date_added"] < manifests["objects"][x]["date_added"] @@ -294,9 +294,8 @@ def test_get_objects_limit(backend): 'indicator--cd981c25-8042-4166-8945-51178443bdac', 'marking-definition--34098fce-860f-48ae-8e50-ebd3cc5e41da'] - x = 0 for x in range(0, len(correct_order)): - objs["objects"][x]["id"] == correct_order[x] + assert objs["objects"][x]["id"] == correct_order[x] r = backend.client.get( test.GET_OBJECTS_EP + "?limit=3&next=" + r.json["next"], @@ -314,9 +313,9 @@ def test_get_objects_limit(backend): correct_order = ['malware--c0931cc6-c75e-47e5-9036-78fabc95d4ec', 'indicator--6770298f-0fd8-471a-ab8c-1c658a46574e'] - x = 0 + for x in range(0, len(correct_order)): - objs["objects"][x]["id"] == correct_order[x] + assert objs["objects"][x]["id"] == correct_order[x] def test_get_objects_id(backend):