Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test improvement suggestions #31

Open
chazsconi opened this issue Feb 12, 2018 · 3 comments
Open

Integration test improvement suggestions #31

chazsconi opened this issue Feb 12, 2018 · 3 comments

Comments

@chazsconi
Copy link
Collaborator

I suggest the following changes to the integration test:

  1. Create a namespace and run tests that create objects against that namespace - this allows for the namespace to be deleted in a module levelon_exit callback, thus ensuring everything is cleaned up.
  2. Use the alpine image for the pod that is created rather than obmarg/health-proxy as alpine is small and will be pulled quickly.
  3. Do not assume there are no ClusterRoles in the test RBAC Authorization V1 Beta 1 API as this depends on having a fresh K8S installation.
@chazsconi
Copy link
Collaborator Author

I'm quite happy to create a PR for this if you agree.

@obmarg
Copy link
Owner

obmarg commented Feb 12, 2018

  1. Sounds sensible. Guess this would also make it less likely for existing pods to mess up tests.
  2. obmarg/health-proxy is only 8MB, but if alpine itself is smaller then yeah, go for it.
  3. Also seems sensible.

Some good ideas 👍

@obmarg
Copy link
Owner

obmarg commented Feb 13, 2018

Re: 1. - Would it make sense to create a unique namespace for each tests (using a uuid as the name or something). That way integration tests can continue to run async without interfering with each other...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants