Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all TOP level HPO and MP terms have corresponding uPheno classes #948

Open
matentzn opened this issue May 30, 2024 · 10 comments
Assignees

Comments

@matentzn
Copy link
Collaborator

Please review MP and HPO and figure out if they have corresponding uPheno classes.

HP top level classes:

image

MP top level classes:

image

Ideally create a table in Google sheets.

Ask @rays22 for advice if needed!

@sbello
Copy link

sbello commented May 30, 2024

If it helps this is a mapping of the high level HPO terms to high level MP terms
https://docs.google.com/spreadsheets/d/1BJfse2aSST0FFK__FweZREQC-jhrJ2fDwBiG_ieBsR8/edit?usp=sharing

@matentzn
Copy link
Collaborator Author

Very helpful, thanks @sbello

@pnrobinson
Copy link

It would be great to review the top level structure of upheno, which seems very heterogeneous, and it is often hard to find corresponding terms in the source ontologies where one would expect them. It would be great to schedule a workshop to review and discuss this!

@sbello
Copy link

sbello commented May 31, 2024

Agree with @pnrobinson
@matentzn if you would be interested we could put something together for the 2025 Biocuration meeting. The call for workshop proposals is going to go out soon

@matentzn
Copy link
Collaborator Author

It would be good if @ar-ibrahim and @rays22 you could meet with Sue and perhaps draft a concrete proposal for a workshop - Would be nice to run another one!

@ar-ibrahim
Copy link
Contributor

Let me know if this is what you had in mind Nico >> upheno-HPO-MP_mapping spreadsheet

@ar-ibrahim
Copy link
Contributor

Also @sbello and I have agreed to meet in mid-July to draft a workshop for Biocuration 2025.

@matentzn
Copy link
Collaborator Author

Very good, thank you! In the meantime, I will draft something based on the combination of the MP and HPO upper categories. Thanks for your help!!

@matentzn
Copy link
Collaborator Author

@sbello will share another experience with re-designing the upper level of VT

@sbello
Copy link

sbello commented Jun 14, 2024

When we created the top level organization of VT we modified this from MP to expand the systems to cover all vertebrates. It could be helpful to look at the differences.

A few key things:

  • We created the top level sets of systems, subdivisions, and organism to deal with differences in groupings
  • In the systems
  • used alimentary to group gastrointestinal, liver/biliary and pancreas
  • connective tissue groups adipose bone cartilage and more
  • hemolymphoid groups hematopoietic and lymphatic systems
  • Organism subdivision has things like head and neck, thorax, rump
  • Organism has things like behavior, body temperature, growth, basically anything to do with the whole organism

It would also be helpful for the Alliance to consider the next level of organization under cellular phenotype as we need to be able to have a good slim set there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants