-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numbered sub-tasks aren't rendered in reader mode #1395
Comments
Hi @BrianKmdy Thanks ever so much fo reporting this. When you have time, please could you paste in the mark-down used in your images, to save time for whoever works on this? |
I won't have time to look at this for a few days, so in case anyone else has time to look at it, I believe that these are the interesting code locations, as of 1.20.0 tag.
|
I wonder if this relates to #372. |
Also possible related: #1041 Options for (trying to fix display of numbered sub-tasks:
I strongly prefer 2, and hope that it may possibly be easier. |
@schemar If you have time, please could you have a look at the above and share any thoughts? Many thanks! |
I believe that the purpose of If that is correct, I wonder whether the event-based approach described in #1389 might be a way to achieve the same end without needing to futz with rendering in Reading mode? If so, this would make a whole load of reported issues disappear. |
Tasks was never meant to support "numbered tasks". Properly enabling numbered tasks would require quite some changes, I believe. If I recall correctly, "numbered task lists" are not a native markdown feature and were added by Obsidian later. For example: this markdown guide doesn't even list numbered tasks: https://www.markdownguide.org/tools/obsidian/ However, since it is part of Obsidian, Tasks should probably support this? I am not sure what exactly would need to change, though. I would look at the cache class which gathers the tasks and at the Since rendering in reader mode is an ongoing issue, you may consider changing the code so that the inline stuff doesn't get re-rendered. Though that's a bigger change, if I recall correctly. And you may lose some other features like styling if you do that (maybe not...). |
Hi @schemar, Yes, your summary of numbered task lists is correct. The recent 1.20.0 release added support for searching of "numbered tasks". They are intentionally rendered just as bullet lists in search results, and this is documented (in the 3rd warning here: https://obsidian-tasks-group.github.io/obsidian-tasks/getting-started/#limitations-and-warnings) I'm not expecting you to review all these, but for info, the changes that made this possible are:
That's a good point. #877 is being worked on, to add more CSS options - and I just looked to see if the current progress changed InlineRenderer. Luckily, it only adds (very helpful) comments so far: main...esm7:obsidian-tasks:feat-themeability So it does more than just the adding a click-handler, it can hide the global filter too. And maybe other stuff, |
@claremacrae I edited the issue to add the markdown I used for testing |
Thanks! |
Just to confirm that I'm finding the same issue with subitems in task lists, too – in reading mode, there's no indication that a list is folded, nor is it possible to unfold the list. The same applies to task lists with subtasks, and to text items with sublists (tasks or bullets). Tasks appears to nuke the icons/markers indicating folded or foldable lists. If the list is already unfolded, there's no touch-based way to fold it (although you can use the fold/unfold commands). I've restarted Obsidian and disabled/re-enabled Tasks multiple times to double-check this issue. |
Hi @MadaboutDana, Your description sounds like it is touching on multiple other issues. I think they are all known, but just in case not, I would like to investigate. So please could you start a new Q&A Discussion, and paste in as plain text some example tasks, and a screenshot showing how they are rendered for you in reading mode. Please note any other relevant info, such as your current Tasks version, platform you are running on. Thanks in advance. |
Yes, sure. I'll sort that out later today. |
I would appreciate help on this. If anyone is interested in working on this, I would be happy to talk you through the relevant code and help you get started. |
I can try and work on it over the holidays @claremacrae. I would definitely be interested in learning more about the relevant code since I'm not too familiar with this codebase yet. |
Hi @BrianKmdy - great, thank you! I was thinking that now that Canvas is open to all, I could try drawing a diagram or few about key parts of the Tasks source code. In the meantime, feel free to email me (address in GitHub profile) to find a time we can both make... |
Please check that this issue hasn't been reported before.
Expected Behavior
I just realized this while using the latest release after the PR I submitted (#1363). It looks like sub-tasks in numbered task lists aren't being rendered in reader mode.
The expected behavior is that a numbered task list with sub tasks would have all the same items in read and edit mode.
Current behaviour
When you switch to reader mode the sub tasks of numbered task-lists are no longer getting rendered. This only affects numbered task-lists. Bullet point task lists and regular numbered lists are unaffected.
Edit mode
Reader mode
Steps to reproduce
To reproduce just create a numbered task list with sub-tasks and switch to reader mode. Here's the markdown I used for testing:
Which Operating Systems are you using?
Obsidian Version
1.0.3
Tasks Plugin Version
1.20.0
Checks
Possible solution
No response
The text was updated successfully, but these errors were encountered: