Create PredictoorHelper and add submitTruevals function #800
Conversation
trizin
changed the base branch from
main
to
issue797-remove-floatvalue-from-predictoor-contract
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| function submitTruevals( | ||
| address contract_addr, |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
trizin
changed the title
|
can you also add it to deploy-contracts script please? |
| function submitTruevalContracts( | ||
| address[] calldata contract_addrs, | ||
| uint256[][] calldata epoch_starts, | ||
| bool[][] calldata trueVals, |
There was a problem hiding this comment.
why do we have double [] ?
It should be one-dimensional array
There was a problem hiding this comment.
An array of arguments for each contract address
|
can we keep it simple, with one-dimensional arrays ? |
Co-authored-by: Alex Coseru <alex.coseru@gmail.com>
| } | ||
|
|
||
| contract PredictoorHelper { | ||
| address admin; |
Check warning
Code scanning / Slither
State variables that could be declared immutable Warning
To clarify, there are two functions: submitTruevals function submits multiple truevals for one contract. (one dimensional) submitTruevalContracts function submits truevals for multiple contracts. (two dimensional - one per each contract) Both are external functions. |
Co-authored-by: Alex Coseru <alex.coseru@gmail.com>
trizin
merged commit 025280e
into
issue797-remove-floatvalue-from-predictoor-contract
trizin
deleted the
799-add-batchsubmittrueval-function-into-dt3-template
branch
Fixes #799
Changes proposed in this PR: