Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize js deps #842

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Optimize js deps #842

merged 4 commits into from
Nov 21, 2023

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Nov 21, 2023 •
edited
Loading

Closes #841

Changes proposed in this PR:

  • move all deps as devDeps
  • Dockerfile now uses dev env, and not prod

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Nov 21, 2023 •
edited
Loading

Optimize js deps

Generated at commit: 05760c7fef1dd22a6fcb38c527a208b85a2eb535

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
Total		 36
13
1
50
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@alexcos20 alexcos20 self-assigned this Nov 21, 2023
@alexcos20 alexcos20 marked this pull request as ready for review November 21, 2023 17:02
@alexcos20 alexcos20 changed the title remove hardhat-waffle Optimize js deps Nov 21, 2023
@alexcos20 alexcos20 merged commit ca11feb into main Nov 21, 2023
18 checks passed
@alexcos20 alexcos20 deleted the feature/js_optimize branch November 21, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

@trizin trizin Awaiting requested review from trizin

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor dev deps
2 participants
@alexcos20 @trentmc