-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add accesslists contracts #868
Conversation
/** | ||
* @notice Batch Mint only for owner | ||
*/ | ||
function batchMint(address[] memory user,string[] memory tokenURI) external onlyOwner |
Check notice
Code scanning / Slither
Local variable shadowing Low
- AccessList.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
super._beforeTokenTransfer(from, to, tokenId, batchSize); | ||
} | ||
|
||
function _add(address user, string memory tokenURI) private returns (uint256) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
- AccessList.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
contract AccessList is Ownable, ERC721Enumerable,ERC721URIStorage { | ||
using Counters for Counters.Counter; | ||
Counters.Counter private _tokenIds; | ||
constructor(string memory _name, string memory _symbol) |
Check notice
Code scanning / Slither
Local variable shadowing Low
return newItemId; | ||
} | ||
|
||
function mint(address user, string memory tokenURI) external onlyOwner returns (uint256) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
- AccessList.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
contract AccessList is Ownable, ERC721Enumerable,ERC721URIStorage { | ||
using Counters for Counters.Counter; | ||
Counters.Counter private _tokenIds; | ||
constructor(string memory _name, string memory _symbol) |
Check notice
Code scanning / Slither
Local variable shadowing Low
add accesslists contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much to say on this. I'm assuming it's a copy and paste of standard open zeppelin contracts. If you want a more thorough review, perhaps sdk Berkay?
Feature/template_sapphire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
add access lists contracts