EE10 Compatible Release #345

poikilotherm · 2022-07-25T10:08:36Z

This is a follow up to #304 and related to IQSS/dataverse#8305

Trying to get this rolling with Jakarta EE 10 snapshots, I experienced the following problems:

Module rewrite-integration-cdi uses a lot of CDI stuff that has been deprecated since CDI 1.1/2.0/3.0 and is now removed in 4.0. (FWIW CDI 3.0 Spec HTML)
Module rewrite-integration-faces uses @ManagedBean detection, which has been removed from Faces 4.0
Module config-prettyfaces uses JSP support for JSF which has been removed (No more jakarta.faces.webapp.UIComponentELTag)
...

The text was updated successfully, but these errors were encountered:

poikilotherm · 2022-07-26T16:02:33Z

FWIW: @pdurbin made me create a reproducer things fall over with EE 10: https://github.com/poikilotherm/reproducer-payara6-ee10-jsf

Currently, PrettyFaces is not Jakarta EE 10 compatible. To at least make our WAR deploy until it's fixed, exclude the dependency from it. See also: ocpsoft/rewrite#345

lincolnthree · 2022-10-17T19:37:35Z

Version 6.0.0.Alpha1 with EE10 support has been released and should be in Maven Central soon. Please test and post results!

Mainly to be used to switch versions of dependencies etc.

- Add Jakarta EE9 and EE10 compatible Payara versions - Add configuration to run Arquillian integration tests in a managed instance of Payara - Add JUnit category to skip tests that should be ignored on Payara

…ra, too ocpsoft#345

With CDI 4.0 and Faces 4.0 you need to explicitly enable CDI by providing at least an empty beans.xml file. Adding this to the test deployment makes the test run again.

With CDI 4.0 the default for bean discovery switched to annotated beans only. It is necessary to switch back to the old default of scanning -all- classes. This means that any application using this library via CDI or Jakarta Faces will have to enable this, too!

poikilotherm · 2022-11-03T15:14:22Z

BTW it looks like 6.0.0 is working for Dataverse as an EE 10 app. Needs more testing, though!

pdurbin · 2022-11-03T20:58:07Z

@lincolnthree we are testing away! Thanks! Also, I assume you saw that Payara 6 final is out: https://github.com/payara/Payara/releases/tag/payara-server-6.2022.1

poikilotherm · 2022-11-04T06:54:25Z

@pdurbin I just created #359 to update the EE10 branch 😄

lincolnthree · 2022-11-07T16:49:31Z

@lincolnthree we are testing away! Thanks! Also, I assume you saw that Payara 6 final is out: https://github.com/payara/Payara/releases/tag/payara-server-6.2022.1

Nice! Congratulations on the release! That's a huge milestone and it looks like you beat WildFly? :D

lincolnthree · 2022-11-07T16:50:33Z

Also, I think we should consider updating the Rewrite versioning to mirror EE releases going forward.

E.g.
EE8 --> Rewrite 8.0.0.Final
EE9 --> Rewrite 9.0.0.Final
EE10 --> Rewrite 10.0.0.Final

Thoughts?

poikilotherm · 2022-11-07T17:18:29Z

We could do that if you like it. Dunno if it causes confusion when people see the other releases like 5.0, 6.0 etc on Maven Central. It's your project 😄

At least we should have a nice little table in the README telling everybody about the compatibility matrix.

rafaelstelles · 2023-02-20T15:57:43Z

Hi, I started testing version 6.0.0.Alpha1 with Jakarta EE 10, but I used scope "ClientWindowScoped" I received exception below. If used "RequestScope", work normaly. I need configuration some additional ?

Link to my testing: https://github.com/rafaelstelles/jakartaee-faces-sample

11:40:30,634 FATAL [jakarta.enterprise.resource.webcontainer.faces.context] (default task-1) JSF1072: com.ocpsoft.pretty.PrettyException caught during afterPhase() processing of RESTORE_VIEW 1 : UIComponent-ClientId=, Message=PrettyFaces: Exception occurred while processing <rewrite-ample:#{rewriteAction.name}> for URL </rewrite/index.xhtml>
11:40:30,634 FATAL [jakarta.enterprise.resource.webcontainer.faces.context] (default task-1) PrettyFaces: Exception occurred while processing <rewrite-ample:#{rewriteAction.name}> for URL </rewrite/index.xhtml>: com.ocpsoft.pretty.PrettyException: PrettyFaces: Exception occurred while processing <rewrite-ample:#{rewriteAction.name}> for URL </rewrite/index.xhtml>
        at deployment.jakartaee-faces-sample.war//com.ocpsoft.pretty.faces.beans.ParameterInjector.injectPathParams(ParameterInjector.java:96)
        at deployment.jakartaee-faces-sample.war//com.ocpsoft.pretty.faces.beans.ParameterInjector.injectParameters(ParameterInjector.java:54)
        at deployment.jakartaee-faces-sample.war//com.ocpsoft.pretty.faces.event.PrettyPhaseListener.afterPhase(PrettyPhaseListener.java:102)
        at com.sun.jsf-impl@4.0.0.SP01//com.sun.faces.lifecycle.Phase.handleAfterPhase(Phase.java:148)
        at com.sun.jsf-impl@4.0.0.SP01//com.sun.faces.lifecycle.Phase.doPhase(Phase.java:78)
        at com.sun.jsf-impl@4.0.0.SP01//com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.java:95)
        at com.sun.jsf-impl@4.0.0.SP01//com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:159)
        at jakarta.faces.api//jakarta.faces.webapp.FacesServlet.executeLifecyle(FacesServlet.java:691)
        at jakarta.faces.api//jakarta.faces.webapp.FacesServlet.service(FacesServlet.java:449)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
        at io.undertow.websocket@2.3.0.Final//io.undertow.websockets.jsr.JsrWebSocketFilter.doFilter(JsrWebSocketFilter.java:172)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:67)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at io.smallrye.opentracing-contrib//io.smallrye.opentracing.contrib.jaxrs2.server.SpanFinishingFilter.doFilter(SpanFinishingFilter.java:69)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:67)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at deployment.jakartaee-faces-sample.war//org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:226)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:67)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
        at org.wildfly.security.elytron-web.undertow-server@3.0.0.Final//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.lambda$handleRequest$1(ElytronRunAsHandler.java:68)
        at org.wildfly.security.elytron-base@2.0.0.Final//org.wildfly.security.auth.server.FlexibleIdentityAssociation.runAsFunctionEx(FlexibleIdentityAssociation.java:103)
        at org.wildfly.security.elytron-base@2.0.0.Final//org.wildfly.security.auth.server.Scoped.runAsFunctionEx(Scoped.java:161)
        at org.wildfly.security.elytron-base@2.0.0.Final//org.wildfly.security.auth.server.Scoped.runAs(Scoped.java:73)
        at org.wildfly.security.elytron-web.undertow-server@3.0.0.Final//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.handleRequest(ElytronRunAsHandler.java:67)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:117)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
        at io.undertow.core@2.3.0.Final//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at io.undertow.core@2.3.0.Final//io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
        at io.undertow.core@2.3.0.Final//io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
        at org.wildfly.security.elytron-web.undertow-server-servlet@3.0.0.Final//org.wildfly.elytron.web.undertow.server.servlet.CleanUpHandler.handleRequest(CleanUpHandler.java:38)
        at io.undertow.core@2.3.0.Final//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61)
        at io.undertow.core@2.3.0.Final//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.SendErrorPageHandler.handleRequest(SendErrorPageHandler.java:52)
        at io.undertow.core@2.3.0.Final//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:275)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:134)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:131)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1435)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1435)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1435)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1435)
        at org.wildfly.extension.undertow@27.0.1.Final//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1435)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:255)
        at io.undertow.servlet@2.3.0.Final//io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:100)
        at io.undertow.core@2.3.0.Final//io.undertow.server.Connectors.executeRootHandler(Connectors.java:391)
        at io.undertow.core@2.3.0.Final//io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:859)
        at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
        at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
        at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
        at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
        at org.jboss.xnio@3.8.8.Final//org.xnio.XnioWorker$WorkerThreadFactory$1$1.run(XnioWorker.java:1282)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: jakarta.el.PropertyNotFoundException: Target Unreachable, identifier 'rewriteAction' resolved to null
        at org.glassfish.expressly@5.0.0//org.glassfish.expressly.parser.AstValue.getTarget(AstValue.java:338)
        at org.glassfish.expressly@5.0.0//org.glassfish.expressly.parser.AstValue.getType(AstValue.java:112)
        at org.glassfish.expressly@5.0.0//org.glassfish.expressly.ValueExpressionImpl.getType(ValueExpressionImpl.java:124)
        at org.jboss.weld.core@5.1.0.Final//org.jboss.weld.module.web.el.WeldValueExpression.getType(WeldValueExpression.java:93)
        at deployment.jakartaee-faces-sample.war//com.ocpsoft.pretty.faces.util.FacesElUtils.getExpectedType(FacesElUtils.java:50)
        at deployment.jakartaee-faces-sample.war//com.ocpsoft.pretty.faces.beans.ParameterInjector.injectPathParams(ParameterInjector.java:79)
        ... 62 more

lincolnthree · 2023-02-22T22:39:10Z

Hi @rafaelstelles - Thanks for testing the new version, and for providing a sample application that I can debug. I'll look into this and see what I can find out. It's possible that window scoping may have some issues to be worked out.

lincolnthree · 2023-02-28T23:24:49Z

@rafaelstelles I'm still going to look into this, but could you do me a favor and open a bug/issue for this? Thanks.

rafaelstelles · 2023-03-02T10:52:23Z

@lincolnthree Of course, I just created issue.

pdurbin · 2023-08-30T16:10:20Z

@lincolnthree hi! Any plans to put out a non-snapshot release?

We (Dataverse) are currently using these versions:

    <dependency>
        <groupId>org.ocpsoft.rewrite</groupId>
        <artifactId>rewrite-servlet</artifactId>
        <version>6.0.0-SNAPSHOT</version>
    </dependency>
    <dependency>
        <groupId>org.ocpsoft.rewrite</groupId>
        <artifactId>rewrite-config-prettyfaces</artifactId>
        <version>6.0.0-SNAPSHOT</version>
    </dependency>

A non-snapshot release is desirable so that it's fixed and final.

We do have a couple bugs that might be related to Rewrite/PrettyFaces. I'm happy to open separate issues if you like!

Overall, we're very happy with the snapshot release and would have been dead in the water without it. THANK YOU! ❤️

lincolnthree · 2023-09-07T05:25:18Z

Hey @pdurbin Yes! I think we should cut releases now. I will try to do that this week. Thanks for letting me know that the snapshots have been working. I've been a little hesitant to put them out because (a. I'm super busy), but b. I am running a little blind on the new EE versions. Haven't been able to work in EE for a bit sadly :(

lincolnthree · 2023-09-07T05:25:24Z

Thanks for your support :) And reminders.

pdurbin · 2023-09-07T14:56:03Z

@lincolnthree that's fine. We're happy to be your guinea pigs. 🐹

We'll probably release soon, I'd say tomorrow at soonest but these things are hard to predict. 😅

We'll take the non-SNAPSHOT whenever you put it out. Thanks!

pdurbin · 2023-09-08T21:07:20Z

We just released Dataverse 6.0: https://github.com/IQSS/dataverse/releases/tag/v6.0

We're still using the Rewrite SNAPSHOT, of course. @lincolnthree please let us know when when the non-SNAPSHOT is out and we'll switch to it. Thanks and have a great weekend!

rafaelstelles · 2023-09-28T01:36:06Z

Hi @lincolnthree , any news about the publication of the final version ?

FeanorOfValinor · 2023-10-04T00:16:27Z

I also wanted to add I've been testing 6.0.0-SNAPSHOT with CDI 4 and Faces 4 on Payara 6.2023.9 and it's working great. I'm also looking forward to a final release. Thank you for your hard work on this!

lincolnthree · 2023-10-04T13:42:52Z

Working on this right now. Thanks for all of your help & patience!

lincolnthree · 2023-10-04T20:50:05Z

Update. This has been released as Rewrite version 10.0.0.Final to move in line with the EE spec versioning. I expect it should be in central once the Sonatype sync is run! (Should be tomorrow at latest.)

lincolnthree · 2023-10-04T20:51:41Z

Actually I think it's live NOW!

lincolnthree · 2023-10-04T20:55:14Z

Thanks everyone for their patience and encouragement. This has been a momentous and multi-year effort. Thanks to @pdurbin @codylerum @larsgrefer @poikilotherm and everyone else.

Closing this as COMPLETED!

pdurbin mentioned this issue Jul 25, 2022

EE9 Compatible Release #304

Closed

poikilotherm mentioned this issue Jul 27, 2022

Add Jakarta EE 10 compatibility #349

Merged

poikilotherm added a commit to poikilotherm/ocpsoft-rewrite that referenced this issue Oct 18, 2022

build: add Jakarta EE 10 Maven profile ocpsoft#345

ee0d6f5

Mainly to be used to switch versions of dependencies etc.

poikilotherm added a commit to poikilotherm/ocpsoft-rewrite that referenced this issue Oct 18, 2022

build: update version of Wildfly Arquillian module for EE10 ocpsoft#345

d784be5

poikilotherm added a commit to poikilotherm/ocpsoft-rewrite that referenced this issue Oct 18, 2022

test(config-servlet): ignore ParameterWildcardConfigurationIT on Paya…

2257b09

…ra, too ocpsoft#345

poikilotherm mentioned this issue Oct 18, 2022

Improve EE10 compatibility #350

Merged

2 tasks

poikilotherm mentioned this issue Aug 14, 2023

Payara 6: Move all dependencies to stable jakartified versions IQSS/dataverse#9778

Closed

9 tasks

pdurbin mentioned this issue Aug 24, 2023

encourage Rewrite library to release a non-snapshot of 6.0.0 IQSS/dataverse#9804

Closed

lincolnthree closed this as completed Oct 4, 2023

poikilotherm mentioned this issue Oct 4, 2023

Use stable Rewrite releases for Jakarta EE 10 IQSS/dataverse#9975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EE10 Compatible Release #345

EE10 Compatible Release #345

poikilotherm commented Jul 25, 2022 •

edited

Loading

poikilotherm commented Jul 26, 2022 •

edited

Loading

lincolnthree commented Oct 17, 2022 •

edited

Loading

poikilotherm commented Nov 3, 2022

pdurbin commented Nov 3, 2022

poikilotherm commented Nov 4, 2022

lincolnthree commented Nov 7, 2022

lincolnthree commented Nov 7, 2022

poikilotherm commented Nov 7, 2022

rafaelstelles commented Feb 20, 2023

lincolnthree commented Feb 22, 2023

lincolnthree commented Feb 28, 2023

rafaelstelles commented Mar 2, 2023

pdurbin commented Aug 30, 2023

lincolnthree commented Sep 7, 2023

lincolnthree commented Sep 7, 2023 •

edited

Loading

pdurbin commented Sep 7, 2023

pdurbin commented Sep 8, 2023

rafaelstelles commented Sep 28, 2023

FeanorOfValinor commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

EE10 Compatible Release #345

EE10 Compatible Release #345

Comments

poikilotherm commented Jul 25, 2022 • edited Loading

poikilotherm commented Jul 26, 2022 • edited Loading

lincolnthree commented Oct 17, 2022 • edited Loading

poikilotherm commented Nov 3, 2022

pdurbin commented Nov 3, 2022

poikilotherm commented Nov 4, 2022

lincolnthree commented Nov 7, 2022

lincolnthree commented Nov 7, 2022

poikilotherm commented Nov 7, 2022

rafaelstelles commented Feb 20, 2023

lincolnthree commented Feb 22, 2023

lincolnthree commented Feb 28, 2023

rafaelstelles commented Mar 2, 2023

pdurbin commented Aug 30, 2023

lincolnthree commented Sep 7, 2023

lincolnthree commented Sep 7, 2023 • edited Loading

pdurbin commented Sep 7, 2023

pdurbin commented Sep 8, 2023

rafaelstelles commented Sep 28, 2023

FeanorOfValinor commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

lincolnthree commented Oct 4, 2023

poikilotherm commented Jul 25, 2022 •

edited

Loading

poikilotherm commented Jul 26, 2022 •

edited

Loading

lincolnthree commented Oct 17, 2022 •

edited

Loading

lincolnthree commented Sep 7, 2023 •

edited

Loading