base_url not work

[guochao-chen]

When I use "class: octodns_azure.AzurePrivateProvider", I set the base_url: "https://management.chinacloudapi.cn" to use Azure China API. It did not work, still used the default API "https://management.azure.com", reported error

"azure.core.exceptions.ClientAuthenticationError: Authentication failed: AADSTS500011: The resource principal named https://management.azure.com was not found in the tenant named "

add code "credential_scopes = [self._base_url + "/.default"]" into the init.py , it was fixed.

Is it an issue?

[ross]

That seems like an issue and a good fix. Do you know if the same needs to happen for the non-private client path:

octodns-azure/octodns_azure/__init__.py

Lines 990 to 995 in dea29fe

	self._dns_client = DnsManagementClient(
	credential=self._client_credential,
	subscription_id=self._client_subscription_id,
	retry_policy=self._dns_client_retry_policy,
	base_url=self._base_url,
	)

A PR would be welcome. I won't be able to test it against Azure China, but I can verify that it still works correctly with the default.