From e350960a3ddae5fef9f05b3acdf8d87a027909be Mon Sep 17 00:00:00 2001
From: cortadocodes <cortado.codes@protonmail.com>
Date: Wed, 10 Jul 2024 15:34:00 +0100
Subject: [PATCH] WIP: Temporarily disable local file deletion in runner

skipci
---
 octue/runner.py | 58 ++++++++++++++++++++++++-------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/octue/runner.py b/octue/runner.py
index 64baf57ef..85de334f2 100644
--- a/octue/runner.py
+++ b/octue/runner.py
@@ -453,32 +453,32 @@ def _finalise_and_clean_up(self, analysis, save_diagnostics):
         if save_diagnostics == SAVE_DIAGNOSTICS_ON:
             self.diagnostics.upload()
 
-        if self.delete_local_files:
-            # Delete temporary directories first as this will delete entire downloaded datasets.
-            if temporary_directories:
-                logger.warning(
-                    "Deleting registered temporary directories created during analysis. This is not thread-safe - set "
-                    "`delete_local_files=False` at instantiation of `Runner` to switch this off."
-                )
-
-                for dir in temporary_directories:
-                    logger.debug("Deleting temporary directory at %r.", dir.name)
-                    dir.cleanup()
-
-            # Then delete any datafiles were downloaded separately from a dataset.
-            if downloaded_files:
-                logger.warning(
-                    "Deleting datafiles downloaded during analysis. This is not thread-safe - set "
-                    "`delete_local_files=False` at instantiation of `Runner` to switch this off."
-                )
-
-                for path in downloaded_files:
-                    if not os.path.exists(path):
-                        continue
-
-                    logger.debug("Deleting downloaded file at %r.", path)
-
-                    try:
-                        os.remove(path)
-                    except FileNotFoundError:
-                        logger.debug("Couldn't delete %r - it was already deleted.", path)
+        # if self.delete_local_files:
+        #     # Delete temporary directories first as this will delete entire downloaded datasets.
+        #     if temporary_directories:
+        #         logger.warning(
+        #             "Deleting registered temporary directories created during analysis. This is not thread-safe - set "
+        #             "`delete_local_files=False` at instantiation of `Runner` to switch this off."
+        #         )
+        #
+        #         for dir in temporary_directories:
+        #             logger.debug("Deleting temporary directory at %r.", dir.name)
+        #             dir.cleanup()
+        #
+        #     # Then delete any datafiles were downloaded separately from a dataset.
+        #     if downloaded_files:
+        #         logger.warning(
+        #             "Deleting datafiles downloaded during analysis. This is not thread-safe - set "
+        #             "`delete_local_files=False` at instantiation of `Runner` to switch this off."
+        #         )
+        #
+        #         for path in downloaded_files:
+        #             if not os.path.exists(path):
+        #                 continue
+        #
+        #             logger.debug("Deleting downloaded file at %r.", path)
+        #
+        #             try:
+        #                 os.remove(path)
+        #             except FileNotFoundError:
+        #                 logger.debug("Couldn't delete %r - it was already deleted.", path)