Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update child emulator to work with new event structure #633

Closed
cortadocodes opened this issue Mar 11, 2024 · 0 comments · Fixed by #668
Closed

Update child emulator to work with new event structure #633

cortadocodes opened this issue Mar 11, 2024 · 0 comments · Fixed by #668
Assignees

Comments

@cortadocodes
Copy link
Member

Bug report

What is the current behavior?

The child emulator only works with a list of events and not the events' attributes. The ChildEmulator class also duplicates and modifies some of the event handling code, making its emulation less useful and the code harder to maintain

What is the expected behavior?

For emulation to be faithful, we need to include event attributes and run as much of the same code as a real child as possible.

Proposed Solution

Refactor ChildEmulator to inherit from the new AbstractEventHandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant